resource/aws_api_gateway_vpc_link: Acceptance tests failing since 10 July 2021

[gdavison]

Starting 10 July 2021, the acceptance tests TestAccAWSAPIGatewayVpcLink_basic, TestAccAWSAPIGatewayVpcLink_tags, TestAccAWSAPIGatewayVpcLink_disappears, and TestAccAWSAPIGatewayUsagePlan_tags have been failing with the error

Error: error waiting for API Gateway VPC Link (a1b2c3) deletion: couldn't find resource (21 retries)

Affected Resource

• aws_api_gateway_vpc_link

[lorelei-rupp-imprivata]

I am seeing this consistently in us-west-1 with our API gateway terraform module that uses this resource. Every destroy consistently fails with this. Checking the AWS UI, the link is gone too

`aws_api_gateway_vpc_link.aws_api_gateway_vpc_link_suffix: Still destroying... [id=vs2ly4, 3m40s elapsed]
aws_api_gateway_vpc_link.aws_api_gateway_vpc_link_suffix: Still destroying... [id=vs2ly4, 3m50s elapsed]
aws_api_gateway_vpc_link.aws_api_gateway_vpc_link_suffix: Still destroying... [id=vs2ly4, 4m0s elapsed]
Error: error waiting for API Gateway VPC Link (vs2ly4) deletion: couldn't find resource (21 retries)

We also hit in us-west-2 today as well and us-east-1. I am going to try going backwards in provider versions
`

[lorelei-rupp-imprivata]

@gdavison is that other issue #20221 going to fix this bug?

[lorelei-rupp-imprivata]

Im testing out on 3.49.0 aws provider..,could it be related to this change 4d4335d? This fix was not in 3.49.0

Is the issue here 4d4335d this return should return "1" since its not found vs an error? In prior code you returned 1 here @gdavison

[lorelei-rupp-imprivata]

pinning to 0.49.0 resolves this issue FYI

[lorelei-rupp-imprivata]

@anGie44 @gdavison we still see this issue, related to the prior PR merge potentially... any ideas on a potential fix?

[anGie44]

Hi @lorelei-rupp-imprivata , atleast for the VPCLink destroy errors you've come across, I believe we can update the waiter function's Target status to be empty slice e.g. []string{} instead of the slice with an empty string as seen here (thought it does confuse me a bit why the status returned from apiGatewayVpcLinkStatus doesn't match once the VPCLink is not found):

terraform-provider-aws/aws/internal/service/apigateway/waiter/waiter.go

Lines 15 to 24 in 0f11dda

	func ApiGatewayVpcLinkDeleted(conn *apigateway.APIGateway, vpcLinkId string) error {
	stateConf := resource.StateChangeConf{
	Pending: []string{apigateway.VpcLinkStatusPending,
	apigateway.VpcLinkStatusAvailable,
	apigateway.VpcLinkStatusDeleting},
	Target: []string{""},
	Timeout: ApiGatewayVpcLinkDeleteTimeout,
	MinTimeout: 1 * time.Second,
	Refresh: apiGatewayVpcLinkStatus(conn, vpcLinkId),
	}

[lorelei-rupp-imprivata]

Thanks @anGie44 yeah something was definitely with how the return was being processed in our case, it was failing every time

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.