numeric comparisons for versions

[brenthc]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

---

Closes #21045.

Not sure about adding tests for this, as it'd be necessary to create more than 9 versions so that numeric vs lexical sorting can be verified.

[github-actions]

Welcome @brenthc 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[thornleyk]

@ewbankkit Hi I'm not sure if this 100% working on a non BUILD lex bot which has only $LATEST and no version. I see nowhere where $LATEST will be returned. This code has a significant issue as the old code could have returned > 1 or $LATEST. this code on the other hand now returns > 0 which would not be expected by existing state. You need something like I have in my closed PR like this

if version > 0 {
returnVersion := strconv.Itoa(version)
return returnVersion, nil
}
return LexBotVersionLatest, nil

[ewbankkit]

@thornleyk Thanks - Yes I did correct that in the merged version.

@brenthc Thanks for the contribution 🎉 👏.

I have incorporated these changes into #21122.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.