Cloudwatch cross account #20541
Merged
Cloudwatch cross account #20541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
service/cloudwatch
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @nahratzah 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
added 3 commits
August 12, 2021 16:03
…issions have been set up, which is a manual process.
ewbankkit
removed
the
needs-triage
ewbankkit
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchMetricAlarm_ -timeout 180m
=== RUN TestAccAWSCloudWatchMetricAlarm_basic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_basic
=== RUN TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== RUN TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== RUN TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== RUN TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== PAUSE TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== RUN TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== RUN TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== RUN TestAccAWSCloudWatchMetricAlarm_expression
=== PAUSE TestAccAWSCloudWatchMetricAlarm_expression
=== RUN TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== RUN TestAccAWSCloudWatchMetricAlarm_tags
=== PAUSE TestAccAWSCloudWatchMetricAlarm_tags
=== RUN TestAccAWSCloudWatchMetricAlarm_disappears
=== PAUSE TestAccAWSCloudWatchMetricAlarm_disappears
=== CONT TestAccAWSCloudWatchMetricAlarm_basic
=== CONT TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== CONT TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== CONT TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== CONT TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== CONT TestAccAWSCloudWatchMetricAlarm_tags
=== CONT TestAccAWSCloudWatchMetricAlarm_disappears
=== CONT TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== CONT TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== CONT TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== CONT TestAccAWSCloudWatchMetricAlarm_expression
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (12.81s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_disappears (32.97s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (38.26s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (38.50s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (43.48s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (44.31s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (44.63s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (58.25s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (59.11s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_tags (75.20s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (109.09s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (227.46s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 232.515sGovCloud
% make testacc TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchMetricAlarm_ -timeout 180m
=== RUN TestAccAWSCloudWatchMetricAlarm_basic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_basic
=== RUN TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== RUN TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== RUN TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== RUN TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== PAUSE TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== RUN TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== RUN TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== RUN TestAccAWSCloudWatchMetricAlarm_expression
=== PAUSE TestAccAWSCloudWatchMetricAlarm_expression
=== RUN TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== RUN TestAccAWSCloudWatchMetricAlarm_tags
=== PAUSE TestAccAWSCloudWatchMetricAlarm_tags
=== RUN TestAccAWSCloudWatchMetricAlarm_disappears
=== PAUSE TestAccAWSCloudWatchMetricAlarm_disappears
=== CONT TestAccAWSCloudWatchMetricAlarm_basic
=== CONT TestAccAWSCloudWatchMetricAlarm_tags
=== CONT TestAccAWSCloudWatchMetricAlarm_disappears
=== CONT TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== CONT TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== CONT TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== CONT TestAccAWSCloudWatchMetricAlarm_expression
=== CONT TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== CONT TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== CONT TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== CONT TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (19.59s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_disappears (34.93s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (45.05s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (45.05s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (49.34s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (49.50s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (49.76s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (61.85s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (62.10s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_tags (78.92s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (129.08s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (235.73s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 243.394s
|
@nahratzah Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
haidaraM
added a commit
to haidaraM/terraform-provider-aws
that referenced
this pull request
Sep 7, 2021
Add the missing `account_id` in the documentation. It was added in hashicorp#20541
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #20540
Output from acceptance testing: