Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource for AppStream Stack #20547

Merged
merged 20 commits into from
Aug 24, 2021
Merged

New resource for AppStream Stack #20547

merged 20 commits into from
Aug 24, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Aug 12, 2021 •
edited
Loading

Added a new resource, docs and tests for AppStream Stack called aws_appstream_stack

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6508

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAwsAppStreamStack'                               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppStreamStack -timeout 180m
=== RUN   TestAccAwsAppStreamStack_basic
=== PAUSE TestAccAwsAppStreamStack_basic
=== RUN   TestAccAwsAppStreamStack_disappears
=== PAUSE TestAccAwsAppStreamStack_disappears
=== RUN   TestAccAwsAppStreamStack_complete
=== PAUSE TestAccAwsAppStreamStack_complete
=== RUN   TestAccAwsAppStreamStack_withTags
=== PAUSE TestAccAwsAppStreamStack_withTags
=== CONT  TestAccAwsAppStreamStack_basic
=== CONT  TestAccAwsAppStreamStack_complete
=== CONT  TestAccAwsAppStreamStack_withTags
=== CONT  TestAccAwsAppStreamStack_disappears
--- PASS: TestAccAwsAppStreamStack_disappears (17.68s)
--- PASS: TestAccAwsAppStreamStack_basic (23.41s)
--- PASS: TestAccAwsAppStreamStack_complete (41.19s)
--- PASS: TestAccAwsAppStreamStack_withTags (41.31s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       41.379s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appstream Issues and PRs that pertain to the appstream service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Aug 12, 2021
@YakDriver YakDriver self-assigned this Aug 16, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Aug 16, 2021
YakDriver
YakDriver requested changes Aug 17, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job. This is coming along nicely!

aws/resource_aws_appstream_stack.go Show resolved Hide resolved
aws/resource_aws_appstream_stack.go Outdated Show resolved Hide resolved
aws/resource_aws_appstream_stack.go Outdated Show resolved Hide resolved
aws/resource_aws_appstream_stack.go Show resolved Hide resolved
aws/resource_aws_appstream_stack.go Outdated Show resolved Hide resolved
website/docs/r/appstream_stack.html.markdown
user_settings {
action = "FILE_UPLOAD"
permission = "ENABLED"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

website/docs/r/appstream_stack.html.markdown Outdated

The following arguments are optional:

* `name` - (Optional) Unique name for the AppStream stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be in alphabetical order.

website/docs/r/appstream_stack.html.markdown Outdated

In addition to all arguments above, the following attributes are exported:

* `id` - Unique identifier (ID) of the appstream stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical order.

website/docs/r/appstream_stack.html.markdown
* `name` - (Optional) Unique name for the AppStream stack.
* `name_prefix` - (Optional) Creates a unique name beginning with the specified prefix. Conflicts with `name`.
* `description` - (Optional) Description for the AppStream stack.
* `display_name` - (Optional) Stack name to display.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! No "The " on any of these. 💯

website/docs/r/appstream_stack.html.markdown
* `embed_host_domains` - (Optional) Domains where AppStream 2.0 streaming sessions can be embedded in an iframe. You must approve the domains that you want to host embedded AppStream 2.0 streaming sessions.
* `redirect_url` - (Optional) URL that users are redirected to after their streaming session ends.
* `feedback_url` - (Optional) URL that users are redirected to after they click the Send Feedback link. If no URL is specified, no Send Feedback link is displayed. .
* `storage_connectors` - (Optional) Configuration block for the storage connectors to enable. See below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! "Configuration block" and "See below." 👍

@coderGo93 coderGo93 requested a review from YakDriver August 18, 2021 05:06
YakDriver
YakDriver approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Output from acceptance tests (us-west-2):

--- PASS: TestAccAwsAppStreamStack_disappears (13.23s)
--- PASS: TestAccAwsAppStreamStack_basic (16.94s)
--- PASS: TestAccAwsAppStreamStack_withTags (29.90s)
--- PASS: TestAccAwsAppStreamStack_complete (30.81s)

Output from acceptance tests (GovCloud):

--- PASS: TestAccAwsAppStreamStack_disappears (17.40s)
--- PASS: TestAccAwsAppStreamStack_basic (23.24s)
--- PASS: TestAccAwsAppStreamStack_complete (39.58s)
--- PASS: TestAccAwsAppStreamStack_withTags (39.71s)

@YakDriver YakDriver added this to the v3.56.0 milestone Aug 24, 2021
@YakDriver YakDriver merged commit 8c263a6 into hashicorp:main Aug 24, 2021
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Aug 24, 2021
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@anGie44 anGie44 mentioned this pull request Sep 27, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appstream Issues and PRs that pertain to the appstream service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.56.0
Development

Successfully merging this pull request may close these issues.
3 participants
@coderGo93 @YakDriver @ewbankkit