Update aws_route53_resolver_dnssec_config to be usable and configurable

[aidan-mundy]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There are a few problems with the existing DNSSEC Validation config resource.

• The timeout is slightly too short (in my experience), so the resource will always be tainted if it tries to enable
• The resource's documentation does not reflect how it behaves (resolved by fixing next point)
• The resource relies on creation/deletion to enable/disable the configuration rather than a boolean field

The timeout on the resource should be increased from 5 to 10 minutes. A new field should be added to support enabling/disabling as configuration rather than via creation/deletion.

New or Affected Resource(s)

• aws_route53_resolver_dnssec_config

Potential Terraform Configuration

Before: (creating the resource enables validation, deleting disables validation)

resource "aws_vpc" "this" {
  cidr_block = "10.0.0.0/16"
}

resource "aws_route53_resolver_dnssec_config" "this" {
  resource_id = aws_vpc.this.id
}

After: (creating the resource only makes changes if the state does not match the desired state, deleting does nothing)

resource "aws_vpc" "this" {
  cidr_block = "10.0.0.0/16"
}

resource "aws_route53_resolver_dnssec_config" "this" {
  resource_id = aws_vpc.this.id
  enable_validation = BOOLEAN
}

References

• resource/aws_route53_resolver_dnssec_config - new resource #17012 The MR creating the resource

[aidan-mundy]

Just ran back into this issue and I wanted to clarify something from the original text:
At face value, it doesn't seem very different to have a count field operated by a boolean to enable/disable the resource, but this does not allow for drift detection in the "off" state. This means that Terraform is not managing the resource's state when it believes the DNSSEC is disabled.

[tokiwong]

@aidan-mundy #21797 has been merged and is rolled into the v3.66 milestone

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.