Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration_set on aws_cognito_user_pool always detected as a change #20755

Closed
antdking opened this issue Sep 1, 2021 · 2 comments · Fixed by #20791
Closed

configuration_set on aws_cognito_user_pool always detected as a change #20755

antdking opened this issue Sep 1, 2021 · 2 comments · Fixed by #20791
Labels
bug Addresses a defect in current functionality.
Milestone

Comments

@antdking
Copy link

antdking commented Sep 1, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

$ terraform -v
Terraform v1.0.5
on linux_amd64
+ provider registry.terraform.io/hashicorp/aws v3.56.0
+ provider registry.terraform.io/hashicorp/local v2.1.0
+ provider registry.terraform.io/hashicorp/random v3.1.0

Affected Resource(s)

  • aws_cognito_user_pool

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

note: this is untested, for demonstration purposes only.

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key: https://keybase.io/hashicorp

resource "aws_cognito_user_pool" "user_pool" {
  ...

  email_configuration {
    source_arn            = var.ses-arn
    email_sending_account = "DEVELOPER"
    from_email_address    = "<redacted>"
    configuration_set     = var.configuration-set
  }

Debug Output

Panic Output

Expected Behavior

No changes should be detected

Actual Behavior

configuration_set change is detected:

# module.user-account-dev.module.cognito.aws_cognito_user_pool.user_pool will be updated in-place
  ~ resource "aws_cognito_user_pool" "user_pool" {
        # (11 unchanged attributes hidden)

      ~ email_configuration {
          + configuration_set     = "fo-dev-user-account"
            # (3 unchanged attributes hidden)
        }

        # (13 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

actual data from AWS:

$ aws cognito-idp describe-user-pool --user-pool-id '<redacted>'
...
"EmailConfiguration": {
  "SourceArn": "arn:aws:ses:eu-west-1:<redacted>:identity/<redacted>",
  "EmailSendingAccount": "DEVELOPER",
  "From": "<redacted>",
  "ConfigurationSet": "fo-dev-user-account"
},
...

Steps to Reproduce

  1. terraform apply

Important Factoids

References

It looks like part of the change introducing configuration_set was lost during a code restructure

I'm happy to provide more details if it turns out adding the missing code is not the actual problem here

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/cognito labels Sep 1, 2021
@breathingdust breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 1, 2021
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
2 participants