Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/db_instance - fix update for license_model #20779

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Sep 2, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19009

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBInstance_license'
--- PASS: TestAccAWSDBInstance_license (1822.90s)

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Sep 2, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Sep 3, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review September 3, 2021 06:04
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSDBInstance_license'                        
TestAccAWSDBInstance_license
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_license -timeout 180m
=== RUN   TestAccAWSDBInstance_license
=== PAUSE TestAccAWSDBInstance_license
=== CONT  TestAccAWSDBInstance_license
--- PASS: TestAccAWSDBInstance_license (2367.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2371.274s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSDBInstance_license'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_license -timeout 180m
=== RUN   TestAccAWSDBInstance_license
=== PAUSE TestAccAWSDBInstance_license
=== CONT  TestAccAWSDBInstance_license
--- PASS: TestAccAWSDBInstance_license (1648.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1653.031s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 86670cf into hashicorp:main Sep 13, 2021
@DrFaust92 DrFaust92 deleted the r/db_instance_license_update branch September 13, 2021 14:03
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDS DB instance resource does not change license model on existing RDS instance
3 participants