Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cognito_user_pool - remove lambda config #20952

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20949

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPool_'
--- PASS: TestAccAWSCognitoUserPool_disappears (80.25s)
--- PASS: TestAccAWSCognitoUserPool_withEmailConfiguration (101.44s)
--- PASS: TestAccAWSCognitoUserPool_basic (101.51s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesRemoved (104.54s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesModified (106.06s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (152.38s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributes (152.41s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameAttributes (152.58s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (153.09s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (155.69s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (155.76s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (179.40s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (189.68s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (196.68s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig (205.50s)
--- PASS: TestAccAWSCognitoUserPool_withTags (205.71s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (137.91s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig (219.41s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (221.65s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (131.74s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (81.32s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (136.30s)
--- PASS: TestAccAWSCognitoUserPool_update (246.17s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (152.36s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (259.21s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (123.08s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (121.75s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (197.20s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (158.51s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (159.20s)
--- PASS: TestAccAWSCognitoUserPool_recovery (150.08s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (192.36s)

@github-actions github-actions bot added service/cognito tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Sep 18, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Sep 18, 2021
@ewbankkit ewbankkit self-assigned this Sep 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSCognitoUserPool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPool_ -timeout 180m
=== RUN   TestAccAWSCognitoUserPool_basic
=== PAUSE TestAccAWSCognitoUserPool_basic
=== RUN   TestAccAWSCognitoUserPool_recovery
=== PAUSE TestAccAWSCognitoUserPool_recovery
=== RUN   TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration
=== RUN   TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy
=== PAUSE TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy
=== RUN   TestAccAWSCognitoUserPool_withAdvancedSecurityMode
=== PAUSE TestAccAWSCognitoUserPool_withAdvancedSecurityMode
=== RUN   TestAccAWSCognitoUserPool_withDeviceConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withDeviceConfiguration
=== RUN   TestAccAWSCognitoUserPool_withEmailVerificationMessage
=== PAUSE TestAccAWSCognitoUserPool_withEmailVerificationMessage
=== RUN   TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration
=== RUN   TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration
=== RUN   TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration
=== RUN   TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration
=== RUN   TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration
=== RUN   TestAccAWSCognitoUserPool_SmsAuthenticationMessage
=== PAUSE TestAccAWSCognitoUserPool_SmsAuthenticationMessage
=== RUN   TestAccAWSCognitoUserPool_SmsConfiguration
=== PAUSE TestAccAWSCognitoUserPool_SmsConfiguration
=== RUN   TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId
=== PAUSE TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId
=== RUN   TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn
=== PAUSE TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn
=== RUN   TestAccAWSCognitoUserPool_SmsVerificationMessage
=== PAUSE TestAccAWSCognitoUserPool_SmsVerificationMessage
=== RUN   TestAccAWSCognitoUserPool_withEmailConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withEmailConfiguration
=== RUN   TestAccAWSCognitoUserPool_withEmailConfigurationSource
    resource_aws_cognito_user_pool_test.go:799: 'TEST_AWS_SES_VERIFIED_EMAIL_ARN' not set, skipping test.
--- SKIP: TestAccAWSCognitoUserPool_withEmailConfigurationSource (0.00s)
=== RUN   TestAccAWSCognitoUserPool_withTags
=== PAUSE TestAccAWSCognitoUserPool_withTags
=== RUN   TestAccAWSCognitoUserPool_withAliasAttributes
=== PAUSE TestAccAWSCognitoUserPool_withAliasAttributes
=== RUN   TestAccAWSCognitoUserPool_withUsernameAttributes
=== PAUSE TestAccAWSCognitoUserPool_withUsernameAttributes
=== RUN   TestAccAWSCognitoUserPool_withPasswordPolicy
=== PAUSE TestAccAWSCognitoUserPool_withPasswordPolicy
=== RUN   TestAccAWSCognitoUserPool_withUsernameConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withUsernameConfiguration
=== RUN   TestAccAWSCognitoUserPool_withLambdaConfig
=== PAUSE TestAccAWSCognitoUserPool_withLambdaConfig
=== RUN   TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig
=== PAUSE TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig
=== RUN   TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig
=== PAUSE TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig
=== RUN   TestAccAWSCognitoUserPool_schemaAttributes
=== PAUSE TestAccAWSCognitoUserPool_schemaAttributes
=== RUN   TestAccAWSCognitoUserPool_schemaAttributesRemoved
=== PAUSE TestAccAWSCognitoUserPool_schemaAttributesRemoved
=== RUN   TestAccAWSCognitoUserPool_schemaAttributesModified
=== PAUSE TestAccAWSCognitoUserPool_schemaAttributesModified
=== RUN   TestAccAWSCognitoUserPool_withVerificationMessageTemplate
=== PAUSE TestAccAWSCognitoUserPool_withVerificationMessageTemplate
=== RUN   TestAccAWSCognitoUserPool_update
=== PAUSE TestAccAWSCognitoUserPool_update
=== RUN   TestAccAWSCognitoUserPool_disappears
=== PAUSE TestAccAWSCognitoUserPool_disappears
=== CONT  TestAccAWSCognitoUserPool_basic
=== CONT  TestAccAWSCognitoUserPool_withEmailConfiguration
=== CONT  TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig
=== CONT  TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig
=== CONT  TestAccAWSCognitoUserPool_withLambdaConfig
=== CONT  TestAccAWSCognitoUserPool_withUsernameConfiguration
=== CONT  TestAccAWSCognitoUserPool_withPasswordPolicy
=== CONT  TestAccAWSCognitoUserPool_withTags
=== CONT  TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration
=== CONT  TestAccAWSCognitoUserPool_SmsVerificationMessage
=== CONT  TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn
=== CONT  TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId
=== CONT  TestAccAWSCognitoUserPool_SmsConfiguration
=== CONT  TestAccAWSCognitoUserPool_SmsAuthenticationMessage
=== CONT  TestAccAWSCognitoUserPool_withAliasAttributes
=== CONT  TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration
=== CONT  TestAccAWSCognitoUserPool_withUsernameAttributes
=== CONT  TestAccAWSCognitoUserPool_withDeviceConfiguration
=== CONT  TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration
=== CONT  TestAccAWSCognitoUserPool_withVerificationMessageTemplate
--- PASS: TestAccAWSCognitoUserPool_basic (49.80s)
=== CONT  TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration
--- PASS: TestAccAWSCognitoUserPool_withEmailConfiguration (50.07s)
=== CONT  TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (79.51s)
=== CONT  TestAccAWSCognitoUserPool_withEmailVerificationMessage
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (81.30s)
=== CONT  TestAccAWSCognitoUserPool_schemaAttributesRemoved
--- PASS: TestAccAWSCognitoUserPool_withUsernameAttributes (85.78s)
=== CONT  TestAccAWSCognitoUserPool_schemaAttributesModified
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (85.93s)
=== CONT  TestAccAWSCognitoUserPool_schemaAttributes
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (88.45s)
=== CONT  TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (88.52s)
=== CONT  TestAccAWSCognitoUserPool_disappears
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (89.05s)
=== CONT  TestAccAWSCognitoUserPool_withAdvancedSecurityMode
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (89.06s)
=== CONT  TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (107.86s)
=== CONT  TestAccAWSCognitoUserPool_recovery
--- PASS: TestAccAWSCognitoUserPool_withTags (111.96s)
=== CONT  TestAccAWSCognitoUserPool_update
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (114.03s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig (119.96s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (121.40s)
--- PASS: TestAccAWSCognitoUserPool_disappears (33.78s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (124.05s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (43.04s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesRemoved (51.12s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesModified (46.94s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (132.78s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (61.66s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (143.22s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig (143.30s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributes (58.89s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (57.96s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (148.11s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (103.62s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (69.20s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (112.95s)
--- PASS: TestAccAWSCognitoUserPool_recovery (55.92s)
--- PASS: TestAccAWSCognitoUserPool_update (72.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	188.119s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit removed their assignment Sep 21, 2021
@ewbankkit ewbankkit merged commit 8572c6c into hashicorp:main Sep 21, 2021
@github-actions github-actions bot added this to the v3.60.0 milestone Sep 21, 2021
@DrFaust92 DrFaust92 deleted the r/cognito_user_pool_lambda_remove branch September 21, 2021 14:49
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cognito_user_pool lambda_config fails to delete
2 participants