-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/cognito_user_pool - remove lambda config #20952
r/cognito_user_pool - remove lambda config #20952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAWSCognitoUserPool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPool_ -timeout 180m
=== RUN TestAccAWSCognitoUserPool_basic
=== PAUSE TestAccAWSCognitoUserPool_basic
=== RUN TestAccAWSCognitoUserPool_recovery
=== PAUSE TestAccAWSCognitoUserPool_recovery
=== RUN TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration
=== RUN TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy
=== PAUSE TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy
=== RUN TestAccAWSCognitoUserPool_withAdvancedSecurityMode
=== PAUSE TestAccAWSCognitoUserPool_withAdvancedSecurityMode
=== RUN TestAccAWSCognitoUserPool_withDeviceConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withDeviceConfiguration
=== RUN TestAccAWSCognitoUserPool_withEmailVerificationMessage
=== PAUSE TestAccAWSCognitoUserPool_withEmailVerificationMessage
=== RUN TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration
=== RUN TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration
=== RUN TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration
=== RUN TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration
=== RUN TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration
=== PAUSE TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration
=== RUN TestAccAWSCognitoUserPool_SmsAuthenticationMessage
=== PAUSE TestAccAWSCognitoUserPool_SmsAuthenticationMessage
=== RUN TestAccAWSCognitoUserPool_SmsConfiguration
=== PAUSE TestAccAWSCognitoUserPool_SmsConfiguration
=== RUN TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId
=== PAUSE TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId
=== RUN TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn
=== PAUSE TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn
=== RUN TestAccAWSCognitoUserPool_SmsVerificationMessage
=== PAUSE TestAccAWSCognitoUserPool_SmsVerificationMessage
=== RUN TestAccAWSCognitoUserPool_withEmailConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withEmailConfiguration
=== RUN TestAccAWSCognitoUserPool_withEmailConfigurationSource
resource_aws_cognito_user_pool_test.go:799: 'TEST_AWS_SES_VERIFIED_EMAIL_ARN' not set, skipping test.
--- SKIP: TestAccAWSCognitoUserPool_withEmailConfigurationSource (0.00s)
=== RUN TestAccAWSCognitoUserPool_withTags
=== PAUSE TestAccAWSCognitoUserPool_withTags
=== RUN TestAccAWSCognitoUserPool_withAliasAttributes
=== PAUSE TestAccAWSCognitoUserPool_withAliasAttributes
=== RUN TestAccAWSCognitoUserPool_withUsernameAttributes
=== PAUSE TestAccAWSCognitoUserPool_withUsernameAttributes
=== RUN TestAccAWSCognitoUserPool_withPasswordPolicy
=== PAUSE TestAccAWSCognitoUserPool_withPasswordPolicy
=== RUN TestAccAWSCognitoUserPool_withUsernameConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withUsernameConfiguration
=== RUN TestAccAWSCognitoUserPool_withLambdaConfig
=== PAUSE TestAccAWSCognitoUserPool_withLambdaConfig
=== RUN TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig
=== PAUSE TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig
=== RUN TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig
=== PAUSE TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig
=== RUN TestAccAWSCognitoUserPool_schemaAttributes
=== PAUSE TestAccAWSCognitoUserPool_schemaAttributes
=== RUN TestAccAWSCognitoUserPool_schemaAttributesRemoved
=== PAUSE TestAccAWSCognitoUserPool_schemaAttributesRemoved
=== RUN TestAccAWSCognitoUserPool_schemaAttributesModified
=== PAUSE TestAccAWSCognitoUserPool_schemaAttributesModified
=== RUN TestAccAWSCognitoUserPool_withVerificationMessageTemplate
=== PAUSE TestAccAWSCognitoUserPool_withVerificationMessageTemplate
=== RUN TestAccAWSCognitoUserPool_update
=== PAUSE TestAccAWSCognitoUserPool_update
=== RUN TestAccAWSCognitoUserPool_disappears
=== PAUSE TestAccAWSCognitoUserPool_disappears
=== CONT TestAccAWSCognitoUserPool_basic
=== CONT TestAccAWSCognitoUserPool_withEmailConfiguration
=== CONT TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig
=== CONT TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig
=== CONT TestAccAWSCognitoUserPool_withLambdaConfig
=== CONT TestAccAWSCognitoUserPool_withUsernameConfiguration
=== CONT TestAccAWSCognitoUserPool_withPasswordPolicy
=== CONT TestAccAWSCognitoUserPool_withTags
=== CONT TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration
=== CONT TestAccAWSCognitoUserPool_SmsVerificationMessage
=== CONT TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn
=== CONT TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId
=== CONT TestAccAWSCognitoUserPool_SmsConfiguration
=== CONT TestAccAWSCognitoUserPool_SmsAuthenticationMessage
=== CONT TestAccAWSCognitoUserPool_withAliasAttributes
=== CONT TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration
=== CONT TestAccAWSCognitoUserPool_withUsernameAttributes
=== CONT TestAccAWSCognitoUserPool_withDeviceConfiguration
=== CONT TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration
=== CONT TestAccAWSCognitoUserPool_withVerificationMessageTemplate
--- PASS: TestAccAWSCognitoUserPool_basic (49.80s)
=== CONT TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration
--- PASS: TestAccAWSCognitoUserPool_withEmailConfiguration (50.07s)
=== CONT TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (79.51s)
=== CONT TestAccAWSCognitoUserPool_withEmailVerificationMessage
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (81.30s)
=== CONT TestAccAWSCognitoUserPool_schemaAttributesRemoved
--- PASS: TestAccAWSCognitoUserPool_withUsernameAttributes (85.78s)
=== CONT TestAccAWSCognitoUserPool_schemaAttributesModified
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (85.93s)
=== CONT TestAccAWSCognitoUserPool_schemaAttributes
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (88.45s)
=== CONT TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (88.52s)
=== CONT TestAccAWSCognitoUserPool_disappears
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (89.05s)
=== CONT TestAccAWSCognitoUserPool_withAdvancedSecurityMode
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (89.06s)
=== CONT TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (107.86s)
=== CONT TestAccAWSCognitoUserPool_recovery
--- PASS: TestAccAWSCognitoUserPool_withTags (111.96s)
=== CONT TestAccAWSCognitoUserPool_update
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (114.03s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig (119.96s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (121.40s)
--- PASS: TestAccAWSCognitoUserPool_disappears (33.78s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (124.05s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (43.04s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesRemoved (51.12s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesModified (46.94s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (132.78s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (61.66s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (143.22s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig (143.30s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributes (58.89s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (57.96s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (148.11s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (103.62s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (69.20s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (112.95s)
--- PASS: TestAccAWSCognitoUserPool_recovery (55.92s)
--- PASS: TestAccAWSCognitoUserPool_update (72.75s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 188.119s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20949
Output from acceptance testing: