Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image_uri to data source aws_lambda_function #21015

Conversation

razielgn
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19383

Should I run acceptance tests for this change?

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Sep 23, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @razielgn 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 23, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@razielgn razielgn force-pushed the f-data-source-aws_lambda_function-add-image_uri branch from 7998fa6 to bd0a109 Compare October 24, 2021 18:23
@razielgn
Copy link
Contributor Author

Rebased. 🙌🏻

@razielgn razielgn force-pushed the f-data-source-aws_lambda_function-add-image_uri branch from bd0a109 to b5525db Compare October 24, 2021 18:24
@anGie44 anGie44 self-assigned this Nov 24, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @razielgn 🚀 ! Overall this looked great, just needed a line that sets the image_uri in state.

Output of acceptance tests:

--- PASS: TestAccLambdaFunctionDataSource_environment (45.01s)
--- SKIP: TestAccLambdaFunctionDataSource_image (0.95s)
--- PASS: TestAccLambdaFunctionDataSource_environment (45.01s)
--- PASS: TestAccLambdaFunctionDataSource_alias (269.83s)
--- PASS: TestAccLambdaFunctionDataSource_version (387.83s)
--- PASS: TestAccLambdaFunctionDataSource_basic (669.14s)
--- PASS: TestAccLambdaFunctionDataSource_architectures (669.25s)
--- PASS: TestAccLambdaFunctionDataSource_layers (681.77s)
--- PASS: TestAccLambdaFunctionDataSource_vpc (1225.98s)
--- PASS: TestAccLambdaFunctionDataSource_fileSystem (328.30s)

@anGie44 anGie44 added this to the v3.67.0 milestone Nov 25, 2021
@anGie44 anGie44 merged commit a6ac55b into hashicorp:main Nov 25, 2021
@razielgn
Copy link
Contributor Author

Thanks!

@razielgn razielgn deleted the f-data-source-aws_lambda_function-add-image_uri branch November 25, 2021 08:38
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data/aws_lambda_function retrieve image_uri
4 participants