Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/db_proxy - new data source #21053

Merged
merged 7 commits into from
Sep 30, 2021

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20943.

Output from acceptance testing:

make testacc TESTARGS="-run=TestAccAWSDBProxyDataSource_basic"                                                                         18m 21s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBProxyDataSource_basic -timeout 180m
=== RUN   TestAccAWSDBProxyDataSource_basic
=== PAUSE TestAccAWSDBProxyDataSource_basic
=== CONT  TestAccAWSDBProxyDataSource_basic
--- PASS: TestAccAWSDBProxyDataSource_basic (692.60s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       700.260s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Sep 26, 2021
@kamilturek kamilturek changed the title d/aws_db_proxy - new data source d/db_proxy - new data source Sep 26, 2021
@kamilturek kamilturek marked this pull request as ready for review September 27, 2021 07:16
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 27, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSDBProxyDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBProxyDataSource_basic -timeout 180m
=== RUN   TestAccAWSDBProxyDataSource_basic
=== PAUSE TestAccAWSDBProxyDataSource_basic
=== CONT  TestAccAWSDBProxyDataSource_basic
--- PASS: TestAccAWSDBProxyDataSource_basic (542.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	545.919s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSDBProxyDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBProxyDataSource_basic -timeout 180m
=== RUN   TestAccAWSDBProxyDataSource_basic
=== PAUSE TestAccAWSDBProxyDataSource_basic
=== CONT  TestAccAWSDBProxyDataSource_basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Error creating DB Proxy: InvalidAction: 
        	status code: 400, request id: 7617a7a9-4103-400c-be44-ce5f2808b233
        
          with aws_db_proxy.test,
          on terraform_plugin_test.tf line 91, in resource "aws_db_proxy" "test":
          91: resource "aws_db_proxy" "test" {
        
--- SKIP: TestAccAWSDBProxyDataSource_basic (20.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.887s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 01f38b0 into hashicorp:main Sep 30, 2021
@github-actions github-actions bot added this to the v3.61.0 milestone Sep 30, 2021
@kamilturek kamilturek deleted the f-data_source_aws_db_proxy branch September 30, 2021 21:30
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data source for aws_db_proxy
3 participants