Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to stop an instance before trying to remove an attached volume #21144

Merged
merged 5 commits into from
Oct 4, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8602
This is a cherry-picked continuation of #8602 (unable to make edits to it).

Fixes #6673
Fixes #2084
Fixes #2957
Fixes #4770
Fixes #288
Fixes #1017
Relates #4293
Relates #1991

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSVolumeAttachment_disappears (114.38s)
--- PASS: TestAccAWSVolumeAttachment_stopInstance (117.35s)
--- PASS: TestAccAWSVolumeAttachment_skipDestroy (126.91s)
--- PASS: TestAccAWSVolumeAttachment_basic (130.15s)
--- PASS: TestAccAWSVolumeAttachment_update (164.19s)
--- PASS: TestAccAWSVolumeAttachment_attachStopped (377.79s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSVolumeAttachment_skipDestroy (117.02s)
--- PASS: TestAccAWSVolumeAttachment_basic (117.57s)
--- PASS: TestAccAWSVolumeAttachment_attachStopped (123.17s)
--- PASS: TestAccAWSVolumeAttachment_disappears (135.32s)
--- PASS: TestAccAWSVolumeAttachment_stopInstance (139.20s)
--- PASS: TestAccAWSVolumeAttachment_update (141.49s)

…lume

By stopping the instance, the volume is unmounted in the instance
and the detaching of the volume doesn't run into a timeout

fixes #6673
fixes #2084
fixes #2957
fixes #4770
fixes #288
fixes #1017
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. labels Oct 4, 2021
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Oct 4, 2021
@YakDriver YakDriver merged commit fac01a0 into main Oct 4, 2021
@YakDriver YakDriver deleted the f-stop-instance-volume-attach branch October 4, 2021 23:59
@YakDriver YakDriver added this to the v3.61.0 milestone Oct 4, 2021
@github-actions github-actions bot modified the milestones: v3.61.0, v3.62.0 Oct 5, 2021
@YakDriver YakDriver modified the milestones: v3.62.0, v3.61.0 Oct 5, 2021
github-actions bot pushed a commit that referenced this pull request Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants