-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_elasticache_replication_group: Fix updating tags #21185
Conversation
return resource.ComposeAggregateTestCheckFunc(checks...) | ||
} | ||
|
||
func testAccCheckResourceTags(resourceName string, kvs []kvp) []resource.TestCheckFunc { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this to the new acctest
package after the service package refactor. I'm sure there are a number of places where this logic is duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my plan 😃
Needs a CHANGELOG entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_ -timeout 180m
=== RUN TestAccAWSElasticacheReplicationGroup_basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_basic
=== RUN TestAccAWSElasticacheReplicationGroup_Uppercase
=== PAUSE TestAccAWSElasticacheReplicationGroup_Uppercase
=== RUN TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
=== PAUSE TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
=== RUN TestAccAWSElasticacheReplicationGroup_disappears
=== PAUSE TestAccAWSElasticacheReplicationGroup_disappears
=== RUN TestAccAWSElasticacheReplicationGroup_updateDescription
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateDescription
=== RUN TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
=== RUN TestAccAWSElasticacheReplicationGroup_updateNodeSize
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateNodeSize
=== RUN TestAccAWSElasticacheReplicationGroup_updateParameterGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateParameterGroup
=== RUN TestAccAWSElasticacheReplicationGroup_vpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_vpc
=== RUN TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
=== RUN TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== RUN TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
=== RUN TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== PAUSE TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
=== RUN TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
=== PAUSE TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
=== RUN TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== RUN TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== RUN TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== RUN TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== PAUSE TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
=== RUN TestAccAWSElasticacheReplicationGroup_tags
=== PAUSE TestAccAWSElasticacheReplicationGroup_tags
=== RUN TestAccAWSElasticacheReplicationGroup_FinalSnapshot
=== PAUSE TestAccAWSElasticacheReplicationGroup_FinalSnapshot
=== RUN TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
=== RUN TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== CONT TestAccAWSElasticacheReplicationGroup_basic
=== CONT TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
=== CONT TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== CONT TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== CONT TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
=== CONT TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== CONT TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType (19.38s)
=== CONT TestAccAWSElasticacheReplicationGroup_FinalSnapshot
--- PASS: TestAccAWSElasticacheReplicationGroup_FinalSnapshot (905.68s)
=== CONT TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover (1.90s)
=== CONT TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (0.83s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (1051.44s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1123.57s)
=== CONT TestAccAWSElasticacheReplicationGroup_tags
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType (1164.01s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (1355.85s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary (1396.03s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1397.53s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange (1446.52s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (1480.93s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1514.56s)
=== CONT TestAccAWSElasticacheReplicationGroup_updateNodeSize
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize (1550.21s)
=== CONT TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster (1570.21s)
=== CONT TestAccAWSElasticacheReplicationGroup_multiAzInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled (1615.47s)
=== CONT TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode (724.52s)
=== CONT TestAccAWSElasticacheReplicationGroup_disappears
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown (1800.45s)
=== CONT TestAccAWSElasticacheReplicationGroup_vpc
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic (1960.54s)
=== CONT TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (1007.47s)
=== CONT TestAccAWSElasticacheReplicationGroup_updateParameterGroup
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup (831.57s)
=== CONT TestAccAWSElasticacheReplicationGroup_updateDescription
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (2290.98s)
=== CONT TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic (2430.61s)
=== CONT TestAccAWSElasticacheReplicationGroup_Uppercase
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (878.79s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (836.04s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears (2675.18s)
--- PASS: TestAccAWSElasticacheReplicationGroup_disappears (1117.18s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1298.05s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (869.30s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1345.78s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (795.32s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (1021.37s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (740.85s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup (1959.31s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full (3344.77s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1874.53s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc (1866.29s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp (2607.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown (2813.97s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown (2565.37s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic (4006.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp (3189.73s)
--- PASS: TestAccAWSElasticacheReplicationGroup_EngineVersion_Update (3882.60s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 6177.996s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_ -timeout 180m
=== RUN TestAccAWSElasticacheReplicationGroup_basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_basic
=== RUN TestAccAWSElasticacheReplicationGroup_Uppercase
=== PAUSE TestAccAWSElasticacheReplicationGroup_Uppercase
=== RUN TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
=== PAUSE TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
=== RUN TestAccAWSElasticacheReplicationGroup_disappears
=== PAUSE TestAccAWSElasticacheReplicationGroup_disappears
=== RUN TestAccAWSElasticacheReplicationGroup_updateDescription
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateDescription
=== RUN TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
=== RUN TestAccAWSElasticacheReplicationGroup_updateNodeSize
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateNodeSize
=== RUN TestAccAWSElasticacheReplicationGroup_updateParameterGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_updateParameterGroup
=== RUN TestAccAWSElasticacheReplicationGroup_vpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_vpc
=== RUN TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
=== RUN TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== RUN TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
=== RUN TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== PAUSE TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
=== RUN TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
=== PAUSE TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
=== RUN TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
=== PAUSE TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
=== RUN TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== RUN TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== RUN TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== PAUSE TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== RUN TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== PAUSE TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== RUN TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
=== PAUSE TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
=== RUN TestAccAWSElasticacheReplicationGroup_tags
=== PAUSE TestAccAWSElasticacheReplicationGroup_tags
=== RUN TestAccAWSElasticacheReplicationGroup_FinalSnapshot
=== PAUSE TestAccAWSElasticacheReplicationGroup_FinalSnapshot
=== RUN TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
=== RUN TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
=== PAUSE TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
=== RUN TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== PAUSE TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== CONT TestAccAWSElasticacheReplicationGroup_basic
=== CONT TestAccAWSElasticacheReplicationGroup_enableSnapshotting
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
=== CONT TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
=== CONT TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
=== CONT TestAccAWSElasticacheReplicationGroup_FinalSnapshot
=== CONT TestAccAWSElasticacheReplicationGroup_tags
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled
=== CONT TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic
=== CONT TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary
provider_test.go:746: AWS_ALTERNATE_REGION partition (aws) does not match AWS_DEFAULT_REGION partition (aws-us-gov)
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears
provider_test.go:746: AWS_ALTERNATE_REGION partition (aws) does not match AWS_DEFAULT_REGION partition (aws-us-gov)
--- FAIL: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Validation_NumNodeGroupsOnSecondary (1.66s)
--- FAIL: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears (1.62s)
=== CONT TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption
=== CONT TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full
provider_test.go:746: AWS_ALTERNATE_REGION partition (aws) does not match AWS_DEFAULT_REGION partition (aws-us-gov)
--- FAIL: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full (1.62s)
=== CONT TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic
provider_test.go:746: AWS_ALTERNATE_REGION partition (aws) does not match AWS_DEFAULT_REGION partition (aws-us-gov)
--- FAIL: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic (1.60s)
=== CONT TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError
=== CONT TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType
provider_test.go:746: AWS_ALTERNATE_REGION partition (aws) does not match AWS_DEFAULT_REGION partition (aws-us-gov)
--- FAIL: TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType (1.61s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode
=== CONT TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic
provider_test.go:746: AWS_ALTERNATE_REGION partition (aws) does not match AWS_DEFAULT_REGION partition (aws-us-gov)
--- FAIL: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_ClusterMode_Basic (1.63s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown
=== CONT TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType
provider_test.go:746: AWS_ALTERNATE_REGION partition (aws) does not match AWS_DEFAULT_REGION partition (aws-us-gov)
--- FAIL: TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType (1.62s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (8.29s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover (14.59s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown
=== CONT TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
resource_aws_elasticache_replication_group_test.go:1005: Step 1/1 error: Error running apply: exit status 1
Error: error creating ElastiCache Replication Group (tf-8tg1h9zi3i): InvalidParameterValue: Cluster encryption using KMS key is not suppored in this region: us-gov-west-1
status code: 400, request id: 21874c86-cda7-4a94-8fef-1c52ddf686a0
with aws_elasticache_replication_group.bar,
on terraform_plugin_test.tf line 55, in resource "aws_elasticache_replication_group" "bar":
55: resource "aws_elasticache_replication_group" "bar" {
--- FAIL: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (40.83s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode (1165.10s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1279.20s)
=== CONT TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1536.26s)
=== CONT TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (1546.13s)
=== CONT TestAccAWSElasticacheReplicationGroup_updateNodeSize
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (1598.81s)
=== CONT TestAccAWSElasticacheReplicationGroup_multiAzInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1722.20s)
=== CONT TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup (778.90s)
=== CONT TestAccAWSElasticacheReplicationGroup_vpc
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup (1939.98s)
=== CONT TestAccAWSElasticacheReplicationGroup_updateParameterGroup
--- PASS: TestAccAWSElasticacheReplicationGroup_FinalSnapshot (1996.56s)
=== CONT TestAccAWSElasticacheReplicationGroup_disappears
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize (2008.87s)
=== CONT TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (2071.00s)
=== CONT TestAccAWSElasticacheReplicationGroup_updateDescription
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (720.59s)
=== CONT TestAccAWSElasticacheReplicationGroup_EngineVersion_Update
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown (2296.02s)
=== CONT TestAccAWSElasticacheReplicationGroup_Uppercase
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange (2300.26s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1065.97s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (2373.53s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown (2431.32s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (866.48s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp (2590.32s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (678.70s)
--- PASS: TestAccAWSElasticacheReplicationGroup_disappears (730.66s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown (2771.59s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (812.74s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic (2903.95s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (1057.03s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (998.45s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (751.58s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled (3085.79s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster (3226.35s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1801.31s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc (1723.07s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp (3947.54s)
--- PASS: TestAccAWSElasticacheReplicationGroup_EngineVersion_Update (3503.78s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 5765.572s
FAIL
make: *** [testacc] Error 1
The failure is known: #17224.
Test failure addressed: % make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId -timeout 180m
=== RUN TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== PAUSE TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
=== CONT TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating ElastiCache Replication Group (tf-bfrelgiwfy): InvalidParameterValue: Cluster encryption using KMS key is not suppored in this region: us-gov-west-1
status code: 400, request id: e84f91ee-e7a9-4dc8-88bb-cde538791508
with aws_elasticache_replication_group.bar,
on terraform_plugin_test.tf line 55, in resource "aws_elasticache_replication_group" "bar":
55: resource "aws_elasticache_replication_group" "bar" {
--- SKIP: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (20.20s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 24.485s |
This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
The resource
aws_elasticache_replication_group
was not correctly updating the tags on the replication group, and was only updating tags on the member clusters. This also fixes tagging member clusters when scaling up.Closes #20695
Closes #18449
Closes #18116
Closes #17224
Output from acceptance testing: