Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/ses_configuration_set - correct ARN #21188

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21131. It corrects ARN as per docs.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSSESConfigurationSet"                                                3m 32s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet -timeout 180m
=== RUN   TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN   TestAccAWSSESConfigurationSet_sendingEnabled
=== PAUSE TestAccAWSSESConfigurationSet_sendingEnabled
=== RUN   TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_update_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_disappears
=== PAUSE TestAccAWSSESConfigurationSet_disappears
=== CONT  TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_disappears
=== CONT  TestAccAWSSESConfigurationSet_basic
=== CONT  TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== CONT  TestAccAWSSESConfigurationSet_sendingEnabled
=== CONT  TestAccAWSSESConfigurationSet_update_deliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptions
--- PASS: TestAccAWSSESConfigurationSet_disappears (25.54s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (32.88s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (33.48s)
--- PASS: TestAccAWSSESConfigurationSet_basic (41.60s)
--- PASS: TestAccAWSSESConfigurationSet_reputationMetricsEnabled (70.45s)
--- PASS: TestAccAWSSESConfigurationSet_sendingEnabled (72.45s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (74.03s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (95.90s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       105.279s```

@github-actions github-actions bot added service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Oct 6, 2021
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 6, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSSESConfigurationSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet_ -timeout 180m
=== RUN   TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN   TestAccAWSSESConfigurationSet_sendingEnabled
=== PAUSE TestAccAWSSESConfigurationSet_sendingEnabled
=== RUN   TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_update_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_disappears
=== PAUSE TestAccAWSSESConfigurationSet_disappears
=== CONT  TestAccAWSSESConfigurationSet_basic
=== CONT  TestAccAWSSESConfigurationSet_disappears
=== CONT  TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== CONT  TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_update_deliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_sendingEnabled
--- PASS: TestAccAWSSESConfigurationSet_disappears (17.18s)
--- PASS: TestAccAWSSESConfigurationSet_basic (21.86s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (21.93s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (23.90s)
--- PASS: TestAccAWSSESConfigurationSet_reputationMetricsEnabled (43.47s)
--- PASS: TestAccAWSSESConfigurationSet_sendingEnabled (43.62s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (45.51s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (56.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.935s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 18dfed5 into hashicorp:main Oct 7, 2021
@github-actions github-actions bot added this to the v3.62.0 milestone Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kamilturek kamilturek deleted the d-aws_ses_incorrect_arn branch February 11, 2022 16:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ses Issues and PRs that pertain to the ses service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ses_configuration_set returns incorrect ARN
3 participants