Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/route53_key_signing_key: also deactivate keys with ACTION_NEEDED status #21369

Merged
merged 2 commits into from
Oct 19, 2021
Merged

r/route53_key_signing_key: also deactivate keys with ACTION_NEEDED status #21369

merged 2 commits into from
Oct 19, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Oct 19, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21368

Output from acceptance testing:

SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_route53_key_signing_key make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_route53_key_signing_key -timeout 60m
2021/10/19 09:53:09 [DEBUG] Running Sweepers for region (us-west-2):
2021/10/19 09:53:09 [DEBUG] Running Sweeper (aws_route53_key_signing_key) in region (us-west-2)
2021/10/19 09:53:09 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 09:53:09 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 09:53:09 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 09:53:10 [DEBUG] Skipping Route53 Hosted Zone (terraform-provider-aws-acctest-acm.com): /hostedzone/Z091582589QQJMEZ8UU8
2021/10/19 09:53:11 [DEBUG] Skipping Route53 Hosted Zone (acmetest.hashicorp.engineering): /hostedzone/Z022334616ZZZRNNSFC1G
2021/10/19 09:53:11 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z0222805331QKS9S2298T
2021/10/19 09:53:11 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z02228002WOHJFDCCKJQS
2021/10/19 09:53:11 [DEBUG] Completed Sweeper (aws_route53_key_signing_key) in region (us-west-2) in 1.697056775s
2021/10/19 09:53:11 Completed Sweepers for region (us-west-2) in 1.697200226s
2021/10/19 09:53:11 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_route53_key_signing_key
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	3.690s

@github-actions github-actions bot added service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR. labels Oct 19, 2021
@anGie44 anGie44 changed the title r/route53_key_signing_key: also deactivate keys with 'ACTION_NEEDED' status r/route53_key_signing_key: also deactivate keys with ACTION_NEEDED status Oct 19, 2021
@ewbankkit
Copy link
Contributor

ewbankkit commented Oct 19, 2021 •
edited
Loading

Could you also please add the -tags=sweep option in the make sweep target?
And change the default SWEEP_DIR to ./internal/sweep.

ewbankkit
ewbankkit approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% SWEEP=us-east-1,us-east-2,us-west-1,us-west-2 SWEEPARGS=-sweep-run=aws_route53_key_signing_key make sweep                          
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-east-1,us-east-2,us-west-1,us-west-2 -sweep-run=aws_route53_key_signing_key -timeout 60m
2021/10/19 11:01:51 [DEBUG] Running Sweepers for region (us-east-1):
2021/10/19 11:01:51 [DEBUG] Running Sweeper (aws_route53_key_signing_key) in region (us-east-1)
2021/10/19 11:01:51 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 11:01:51 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:01:52 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:01:53 [DEBUG] Skipping Route53 Hosted Zone (terraform-provider-aws-acctest-acm.com): /hostedzone/Z091582589QQJMEZ8UU8
2021/10/19 11:01:54 [DEBUG] Skipping Route53 Hosted Zone (acmetest.hashicorp.engineering): /hostedzone/Z022334616ZZZRNNSFC1G
2021/10/19 11:01:54 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z0222805331QKS9S2298T
2021/10/19 11:01:54 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z02228002WOHJFDCCKJQS
2021/10/19 11:01:54 [DEBUG] Completed Sweeper (aws_route53_key_signing_key) in region (us-east-1) in 2.688809613s
2021/10/19 11:01:54 Completed Sweepers for region (us-east-1) in 2.688968881s
2021/10/19 11:01:54 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_route53_key_signing_key
2021/10/19 11:01:54 [DEBUG] Running Sweepers for region (us-east-2):
2021/10/19 11:01:54 [DEBUG] Running Sweeper (aws_route53_key_signing_key) in region (us-east-2)
2021/10/19 11:01:54 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 11:01:54 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:01:54 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:01:55 [DEBUG] Skipping Route53 Hosted Zone (terraform-provider-aws-acctest-acm.com): /hostedzone/Z091582589QQJMEZ8UU8
2021/10/19 11:01:55 [DEBUG] Skipping Route53 Hosted Zone (acmetest.hashicorp.engineering): /hostedzone/Z022334616ZZZRNNSFC1G
2021/10/19 11:01:55 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z0222805331QKS9S2298T
2021/10/19 11:01:55 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z02228002WOHJFDCCKJQS
2021/10/19 11:01:55 [DEBUG] Completed Sweeper (aws_route53_key_signing_key) in region (us-east-2) in 1.208293468s
2021/10/19 11:01:55 Completed Sweepers for region (us-east-2) in 1.208306234s
2021/10/19 11:01:55 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_route53_key_signing_key
2021/10/19 11:01:55 [DEBUG] Running Sweepers for region (us-west-1):
2021/10/19 11:01:55 [DEBUG] Running Sweeper (aws_route53_key_signing_key) in region (us-west-1)
2021/10/19 11:01:55 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 11:01:55 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:01:55 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:01:56 [DEBUG] Skipping Route53 Hosted Zone (terraform-provider-aws-acctest-acm.com): /hostedzone/Z091582589QQJMEZ8UU8
2021/10/19 11:01:56 [DEBUG] Skipping Route53 Hosted Zone (acmetest.hashicorp.engineering): /hostedzone/Z022334616ZZZRNNSFC1G
2021/10/19 11:01:56 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z0222805331QKS9S2298T
2021/10/19 11:01:56 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z02228002WOHJFDCCKJQS
2021/10/19 11:01:56 [DEBUG] Completed Sweeper (aws_route53_key_signing_key) in region (us-west-1) in 1.403245717s
2021/10/19 11:01:56 Completed Sweepers for region (us-west-1) in 1.403257049s
2021/10/19 11:01:56 Sweeper Tests for region (us-west-1) ran successfully:
	- aws_route53_key_signing_key
2021/10/19 11:01:56 [DEBUG] Running Sweepers for region (us-west-2):
2021/10/19 11:01:56 [DEBUG] Running Sweeper (aws_route53_key_signing_key) in region (us-west-2)
2021/10/19 11:01:56 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 11:01:56 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:01:57 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:01:57 [DEBUG] Skipping Route53 Hosted Zone (terraform-provider-aws-acctest-acm.com): /hostedzone/Z091582589QQJMEZ8UU8
2021/10/19 11:01:58 [DEBUG] Skipping Route53 Hosted Zone (acmetest.hashicorp.engineering): /hostedzone/Z022334616ZZZRNNSFC1G
2021/10/19 11:01:58 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z0222805331QKS9S2298T
2021/10/19 11:01:58 [DEBUG] Skipping Route53 Hosted Zone (tfacc.hashicorptest.com): /hostedzone/Z02228002WOHJFDCCKJQS
2021/10/19 11:01:58 [DEBUG] Completed Sweeper (aws_route53_key_signing_key) in region (us-west-2) in 1.510652103s
2021/10/19 11:01:58 Completed Sweepers for region (us-west-2) in 1.510664837s
2021/10/19 11:01:58 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_route53_key_signing_key
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	10.910s

@anGie44 anGie44 force-pushed the td-route53-key-signing-key-delete branch from 908c35b to 9144f51 Compare October 19, 2021 15:07
@anGie44 anGie44 mentioned this pull request Oct 19, 2021
Merged
@anGie44 anGie44 added this to the v3.64.0 milestone Oct 19, 2021
@anGie44 anGie44 merged commit 6e45b53 into main Oct 19, 2021
@anGie44 anGie44 deleted the td-route53-key-signing-key-delete branch October 19, 2021 15:43
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affect the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly on in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.

sweep/route53: error sweeping when The specified hosted zone contains DNSSEC Key Signing Keys
3 participants
@anGie44 @ewbankkit @zhelding