Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added prometheus rule group namespace #21470

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Added prometheus rule group namespace #21470

merged 2 commits into from
Oct 25, 2021

Conversation

stijndehaes
Copy link
Contributor

@stijndehaes stijndehaes commented Oct 25, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21236

Output from acceptance testing:

$ make testacc PKG_NAME=internal/service/prometheus TESTARGS='-run=TestAccPrometheusRuleGroupNamespace'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/prometheus/... -v -count 1 -parallel 20 -run=TestAccPrometheusRuleGroupNamespace -timeout 180m
=== RUN   TestAccPrometheusRuleGroupNamespace_basic
=== PAUSE TestAccPrometheusRuleGroupNamespace_basic
=== RUN   TestAccPrometheusRuleGroupNamespace_disappears
=== PAUSE TestAccPrometheusRuleGroupNamespace_disappears
=== CONT  TestAccPrometheusRuleGroupNamespace_basic
=== CONT  TestAccPrometheusRuleGroupNamespace_disappears
--- PASS: TestAccPrometheusRuleGroupNamespace_disappears (151.89s)
--- PASS: TestAccPrometheusRuleGroupNamespace_basic (266.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/prometheus 268.181s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/prometheusservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2021
@stijndehaes stijndehaes force-pushed the f-aws_prometheus_rule_group_namespace branch 2 times, most recently from 29d333a to 3d8b2c6 Compare October 25, 2021 07:47
@stijndehaes stijndehaes force-pushed the f-aws_prometheus_rule_group_namespace branch from 3d8b2c6 to c1af8f2 Compare October 25, 2021 08:08
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 25, 2021
ewbankkit
ewbankkit approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG_NAME=internal/service/prometheus TESTARGS='-run=TestAccPrometheusRuleGroupNamespace'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/prometheus/... -v -count 1 -parallel 20 -run=TestAccPrometheusRuleGroupNamespace -timeout 180m
=== RUN   TestAccPrometheusRuleGroupNamespace_basic
=== PAUSE TestAccPrometheusRuleGroupNamespace_basic
=== RUN   TestAccPrometheusRuleGroupNamespace_disappears
=== PAUSE TestAccPrometheusRuleGroupNamespace_disappears
=== CONT  TestAccPrometheusRuleGroupNamespace_basic
=== CONT  TestAccPrometheusRuleGroupNamespace_disappears
--- PASS: TestAccPrometheusRuleGroupNamespace_disappears (93.61s)
--- PASS: TestAccPrometheusRuleGroupNamespace_basic (230.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/prometheus	237.750s

@ewbankkit ewbankkit merged commit 274cb27 into hashicorp:main Oct 25, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 25, 2021
@stijndehaes stijndehaes deleted the f-aws_prometheus_rule_group_namespace branch October 26, 2021 06:17
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.

prometheus: Alertmanager definition, RuleGroups namespace
2 participants
@stijndehaes @ewbankkit