-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/datasync_s3_location - add validation agent_arns
, s3_bucket_arn
and s3_config. bucket_access_role_arn
#21661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc PKG_NAME=internal/service/datasync TESTARGS='-run=TestAccDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run=TestAccDataSyncLocationS3_ -timeout 180m
=== RUN TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== CONT TestAccDataSyncLocationS3_basic
=== CONT TestAccDataSyncLocationS3_tags
=== CONT TestAccDataSyncLocationS3_disappears
=== CONT TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_storageClass (35.39s)
--- PASS: TestAccDataSyncLocationS3_basic (46.42s)
--- PASS: TestAccDataSyncLocationS3_disappears (48.60s)
--- PASS: TestAccDataSyncLocationS3_tags (91.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 97.583s
GovCloud
% make testacc PKG_NAME=internal/service/datasync TESTARGS='-run=TestAccDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run=TestAccDataSyncLocationS3_ -timeout 180m
=== RUN TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== CONT TestAccDataSyncLocationS3_basic
=== CONT TestAccDataSyncLocationS3_tags
=== CONT TestAccDataSyncLocationS3_disappears
=== CONT TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_storageClass (34.24s)
--- PASS: TestAccDataSyncLocationS3_disappears (38.53s)
--- PASS: TestAccDataSyncLocationS3_basic (41.86s)
--- PASS: TestAccDataSyncLocationS3_tags (94.35s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 98.014s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: