Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/datasync_s3_location - add validation agent_arns, s3_bucket_arn and s3_config. bucket_access_role_arn #21661

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc PKG_NAME=internal/service/datasync TESTARGS='-run=TestAccDataSyncLocationS3_'
--- PASS: TestAccDataSyncLocationS3_storageClass (76.79s)
--- PASS: TestAccDataSyncLocationS3_disappears (82.97s)
--- PASS: TestAccDataSyncLocationS3_basic (85.00s)
--- PASS: TestAccDataSyncLocationS3_tags (209.89s)

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/datasync Issues and PRs that pertain to the datasync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 6, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG_NAME=internal/service/datasync TESTARGS='-run=TestAccDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run=TestAccDataSyncLocationS3_ -timeout 180m
=== RUN   TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN   TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN   TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN   TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== CONT  TestAccDataSyncLocationS3_basic
=== CONT  TestAccDataSyncLocationS3_tags
=== CONT  TestAccDataSyncLocationS3_disappears
=== CONT  TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_storageClass (35.39s)
--- PASS: TestAccDataSyncLocationS3_basic (46.42s)
--- PASS: TestAccDataSyncLocationS3_disappears (48.60s)
--- PASS: TestAccDataSyncLocationS3_tags (91.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	97.583s
GovCloud
% make testacc PKG_NAME=internal/service/datasync TESTARGS='-run=TestAccDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run=TestAccDataSyncLocationS3_ -timeout 180m
=== RUN   TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN   TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN   TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN   TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== CONT  TestAccDataSyncLocationS3_basic
=== CONT  TestAccDataSyncLocationS3_tags
=== CONT  TestAccDataSyncLocationS3_disappears
=== CONT  TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_storageClass (34.24s)
--- PASS: TestAccDataSyncLocationS3_disappears (38.53s)
--- PASS: TestAccDataSyncLocationS3_basic (41.86s)
--- PASS: TestAccDataSyncLocationS3_tags (94.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	98.014s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 98e5a72 into hashicorp:main Nov 8, 2021
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 8, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the datasync_s3_validation branch December 27, 2021 11:29
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/datasync Issues and PRs that pertain to the datasync service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants