Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_appstream_fleet stream_view does not work #21718

Closed
cicsyd opened this issue Nov 11, 2021 · 2 comments · Fixed by #22395
Closed

aws_appstream_fleet stream_view does not work #21718

cicsyd opened this issue Nov 11, 2021 · 2 comments · Fixed by #22395
Assignees
Labels
bug Addresses a defect in current functionality. service/appstream Issues and PRs that pertain to the appstream service.
Milestone

Comments

@cicsyd
Copy link

cicsyd commented Nov 11, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

1.0.5

Affected Resource(s)

  • aws_appstream_fleet

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "aws_appstream_fleet" "workspace_fleet" {
  name = "workspace-fleet"

  compute_capacity {
    desired_instances = 1
  }

  description                        = "Workspace Fleet"
  idle_disconnect_timeout_in_seconds = 3600
  display_name                       = "workspace-fleet"
  enable_default_internet_access     = true
  fleet_type                         = "ON_DEMAND"
  image_name                         = "AppStream-WinServer2019-10-08-2021"
  instance_type                      = "stream.standard.large"
  stream_view                        = "DESKTOP"
  max_user_duration_in_seconds       = 14400

  vpc_config {
    subnet_ids = [aws_subnet.ir[0].id]
    security_group_ids = [aws_security_group.default.id]
  }

  tags = {
    Name = "${var.region_prefix}-appstream-fleet"
    Customer = "Workspace Fleet"
  }
}

Debug Output

None

Panic Output

None

Expected Behavior

Create AWS AppStream Fleet with stream_view set to Desktop

Actual Behavior

Creates AWS AppStream Fleet with stream_view set to App regardless of setting

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/appstream Issues and PRs that pertain to the appstream service. labels Nov 11, 2021
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 11, 2021
@chrobotm
Copy link

chrobotm commented Dec 14, 2021

think all that's missing is

if v, ok := d.GetOk("stream_view"); ok {
	input.StreamView = aws.String(v.(string))
}

from: https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/appstream/fleet.go#L189

could someone more knowledgable check/raise a MR?

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appstream Issues and PRs that pertain to the appstream service.
Projects
None yet
4 participants