-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MaxItems Limit from CreateJobQueue #21737
Remove MaxItems Limit from CreateJobQueue #21737
Conversation
* When creating a new job queue in AWS Batch, there is no actual limit in the API to the number of compute environments you can create. This is controlled by a service quota that can be adjusted. Other systems such as CloudFormation allow you to submit more than 3 compute environments per job queue, so I'm removing that limit here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @pmkuny 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Sorry for not updating the docs as part of the PR. I'll remember that for next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc PKG_NAME=internal/service/batch TESTARGS='-run=TestAccBatchJobQueue_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 20 -run=TestAccBatchJobQueue_basic -timeout 180m
=== RUN TestAccBatchJobQueue_basic
=== PAUSE TestAccBatchJobQueue_basic
=== CONT TestAccBatchJobQueue_basic
--- PASS: TestAccBatchJobQueue_basic (113.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/batch 117.306s
This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
in the API to the number of compute environments you can create. This is
controlled by a service quota that can be adjusted. Other systems such
as CloudFormation allow you to submit more than 3 compute environments
per job queue, so I'm removing that limit here.
Community Note
Relates OR Closes #0000
Output from acceptance testing: