Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MaxItems Limit from CreateJobQueue #21737

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Remove MaxItems Limit from CreateJobQueue #21737

merged 3 commits into from
Nov 11, 2021

Conversation

pmkuny
Copy link
Contributor

@pmkuny pmkuny commented Nov 11, 2021

  • When creating a new job queue in AWS Batch, there is no actual limit
    in the API to the number of compute environments you can create. This is
    controlled by a service quota that can be adjusted. Other systems such
    as CloudFormation allow you to submit more than 3 compute environments
    per job queue, so I'm removing that limit here.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

* When creating a new job queue in AWS Batch, there is no actual limit
in the API to the number of compute environments you can create. This is
controlled by a service quota that can be adjusted. Other systems such
as CloudFormation allow you to submit more than 3 compute environments
per job queue, so I'm removing that limit here.
@github-actions github-actions bot added service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Nov 11, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @pmkuny 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 11, 2021
@ewbankkit ewbankkit self-assigned this Nov 11, 2021
@pmkuny
Copy link
Contributor Author

pmkuny commented Nov 11, 2021

Sorry for not updating the docs as part of the PR. I'll remember that for next time.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG_NAME=internal/service/batch TESTARGS='-run=TestAccBatchJobQueue_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 20 -run=TestAccBatchJobQueue_basic -timeout 180m
=== RUN   TestAccBatchJobQueue_basic
=== PAUSE TestAccBatchJobQueue_basic
=== CONT  TestAccBatchJobQueue_basic
--- PASS: TestAccBatchJobQueue_basic (113.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	117.306s

@ewbankkit ewbankkit merged commit 5aab685 into hashicorp:main Nov 11, 2021
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Nov 11, 2021
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 11, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants