Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudfront_cache_policy: Fix support for 0 values of default_ttl, max_ttl and min_ttl #21793

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 16, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21788.

Output from acceptance testing:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontCachePolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontCachePolicy_ -timeout 180m
=== RUN   TestAccCloudFrontCachePolicy_basic
=== PAUSE TestAccCloudFrontCachePolicy_basic
=== RUN   TestAccCloudFrontCachePolicy_disappears
=== PAUSE TestAccCloudFrontCachePolicy_disappears
=== RUN   TestAccCloudFrontCachePolicy_Items
=== PAUSE TestAccCloudFrontCachePolicy_Items
=== RUN   TestAccCloudFrontCachePolicy_ZeroTTLs
=== PAUSE TestAccCloudFrontCachePolicy_ZeroTTLs
=== CONT  TestAccCloudFrontCachePolicy_basic
=== CONT  TestAccCloudFrontCachePolicy_ZeroTTLs
=== CONT  TestAccCloudFrontCachePolicy_Items
=== CONT  TestAccCloudFrontCachePolicy_disappears
--- PASS: TestAccCloudFrontCachePolicy_disappears (11.20s)
--- PASS: TestAccCloudFrontCachePolicy_ZeroTTLs (15.62s)
--- PASS: TestAccCloudFrontCachePolicy_basic (15.67s)
--- PASS: TestAccCloudFrontCachePolicy_Items (22.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	26.090s

@github-actions github-actions bot added service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Nov 16, 2021
@github-actions github-actions bot added service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 16, 2021
@zhelding
Copy link
Contributor

LGTM! 🚀

@ewbankkit ewbankkit merged commit f2c82bb into main Nov 16, 2021
@ewbankkit ewbankkit deleted the b-aws_cloudfront_cache_policy-default_ttl branch November 16, 2021 19:07
@github-actions github-actions bot added this to the v3.66.0 milestone Nov 16, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudfront Issues and PRs that pertain to the cloudfront service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cloudfront_cache_policy default_ttl value 0 no longer working after provider version 3.38 -> 3.65
2 participants