Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_internet_gateway: Allow available as a pending state during gateway detach #21794

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21792.

Output from acceptance testing:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2InternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2InternetGateway_ -timeout 180m
=== RUN   TestAccEC2InternetGateway_basic
=== PAUSE TestAccEC2InternetGateway_basic
=== RUN   TestAccEC2InternetGateway_disappears
=== PAUSE TestAccEC2InternetGateway_disappears
=== RUN   TestAccEC2InternetGateway_Attachment
=== PAUSE TestAccEC2InternetGateway_Attachment
=== RUN   TestAccEC2InternetGateway_Tags
=== PAUSE TestAccEC2InternetGateway_Tags
=== CONT  TestAccEC2InternetGateway_basic
=== CONT  TestAccEC2InternetGateway_Tags
=== CONT  TestAccEC2InternetGateway_Attachment
=== CONT  TestAccEC2InternetGateway_disappears
--- PASS: TestAccEC2InternetGateway_disappears (12.10s)
--- PASS: TestAccEC2InternetGateway_basic (16.27s)
--- PASS: TestAccEC2InternetGateway_Tags (34.96s)
--- PASS: TestAccEC2InternetGateway_Attachment (45.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	48.975s

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. labels Nov 16, 2021
@zhelding
Copy link
Contributor

LGTM! 🚀

@ewbankkit ewbankkit merged commit 8e40950 into main Nov 16, 2021
@ewbankkit ewbankkit deleted the b-aws_internet_gateway-detach branch November 16, 2021 19:07
@github-actions github-actions bot added this to the v3.66.0 milestone Nov 16, 2021
github-actions bot pushed a commit that referenced this pull request Nov 16, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants