Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account_id for aws_account_alternate_contact to manage member accounts in an AWS organization #21888

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Add account_id for aws_account_alternate_contact to manage member accounts in an AWS organization #21888

merged 5 commits into from
Dec 1, 2021

Conversation

mforutan
Copy link
Contributor

Thank to @shedimon for previous PR: #21789, this is my change to add support for managing member accounts in an AWS organization.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21118

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAccountAlternateContact' PKG_NAME="internal/service/account"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20 -run=TestAccAccountAlternateContact -timeout 180m
=== RUN   TestAccAccountAlternateContact_basic
--- PASS: TestAccAccountAlternateContact_basic (83.90s)
=== RUN   TestAccAccountAlternateContact_disappears
--- PASS: TestAccAccountAlternateContact_disappears (34.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    117.976s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/account Issues and PRs that pertain to the account service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 24, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mforutan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@mforutan
Copy link
Contributor Author

mforutan commented Dec 1, 2021

Hi @ewbankkit, Is it possible to have your feedback on this PR? I need to know if this is a valid implementation.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 1, 2021
@ewbankkit
Copy link
Contributor

% make testacc TESTARGS='-run=TestAccAccountAlternateContact_' PKG_NAME="internal/service/account" 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20 -run=TestAccAccountAlternateContact_ -timeout 180m
=== RUN   TestAccAccountAlternateContact_basic
--- PASS: TestAccAccountAlternateContact_basic (25.06s)
=== RUN   TestAccAccountAlternateContact_disappears
--- PASS: TestAccAccountAlternateContact_disappears (13.34s)
=== RUN   TestAccAccountAlternateContact_accountID
--- PASS: TestAccAccountAlternateContact_accountID (27.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	69.104s

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@mforutan Thanks for the contribution 🎉 👏.
In general everything looks great.
I made some cosmetic changes and added an acceptance test that uses an account_id.

@ewbankkit ewbankkit merged commit 38868a7 into hashicorp:main Dec 1, 2021
@github-actions github-actions bot added this to the v3.68.0 milestone Dec 1, 2021
@mforutan
Copy link
Contributor Author

mforutan commented Dec 1, 2021

Thank you @ewbankkit

@mforutan mforutan deleted the f-alternate_contact_for-accounts branch December 1, 2021 21:35
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/account Issues and PRs that pertain to the account service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants