-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add account_id for aws_account_alternate_contact to manage member accounts in an AWS organization #21888
Add account_id for aws_account_alternate_contact to manage member accounts in an AWS organization #21888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @mforutan 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hi @ewbankkit, Is it possible to have your feedback on this PR? I need to know if this is a valid implementation. |
% make testacc TESTARGS='-run=TestAccAccountAlternateContact_' PKG_NAME="internal/service/account"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20 -run=TestAccAccountAlternateContact_ -timeout 180m
=== RUN TestAccAccountAlternateContact_basic
--- PASS: TestAccAccountAlternateContact_basic (25.06s)
=== RUN TestAccAccountAlternateContact_disappears
--- PASS: TestAccAccountAlternateContact_disappears (13.34s)
=== RUN TestAccAccountAlternateContact_accountID
--- PASS: TestAccAccountAlternateContact_accountID (27.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/account 69.104s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@mforutan Thanks for the contribution 🎉 👏. |
Thank you @ewbankkit |
This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Thank to @shedimon for previous PR: #21789, this is my change to add support for managing member accounts in an AWS organization.
Community Note
Relates #21118
Output from acceptance testing: