-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kms/key: Preserve order in JSON policy lists #21969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccKMSKey_ PKG=kms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20 -run='TestAccKMSKey_' -timeout 180m
=== RUN TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== RUN TestAccKMSKey_disappears
=== PAUSE TestAccKMSKey_disappears
=== RUN TestAccKMSKey_multiRegion
=== PAUSE TestAccKMSKey_multiRegion
=== RUN TestAccKMSKey_asymmetricKey
=== PAUSE TestAccKMSKey_asymmetricKey
=== RUN TestAccKMSKey_Policy_basic
=== PAUSE TestAccKMSKey_Policy_basic
=== RUN TestAccKMSKey_Policy_bypass
=== PAUSE TestAccKMSKey_Policy_bypass
=== RUN TestAccKMSKey_Policy_bypassUpdate
=== PAUSE TestAccKMSKey_Policy_bypassUpdate
=== RUN TestAccKMSKey_Policy_iamRole
=== PAUSE TestAccKMSKey_Policy_iamRole
=== RUN TestAccKMSKey_Policy_iamRoleOrder
=== PAUSE TestAccKMSKey_Policy_iamRoleOrder
=== RUN TestAccKMSKey_Policy_iamServiceLinkedRole
=== PAUSE TestAccKMSKey_Policy_iamServiceLinkedRole
=== RUN TestAccKMSKey_isEnabled
=== PAUSE TestAccKMSKey_isEnabled
=== RUN TestAccKMSKey_tags
=== PAUSE TestAccKMSKey_tags
=== CONT TestAccKMSKey_basic
=== CONT TestAccKMSKey_Policy_iamRole
=== CONT TestAccKMSKey_isEnabled
=== CONT TestAccKMSKey_Policy_iamRoleOrder
=== CONT TestAccKMSKey_Policy_iamServiceLinkedRole
=== CONT TestAccKMSKey_tags
=== CONT TestAccKMSKey_Policy_bypass
=== CONT TestAccKMSKey_Policy_basic
=== CONT TestAccKMSKey_Policy_bypassUpdate
=== CONT TestAccKMSKey_multiRegion
=== CONT TestAccKMSKey_asymmetricKey
=== CONT TestAccKMSKey_disappears
--- PASS: TestAccKMSKey_disappears (19.10s)
--- PASS: TestAccKMSKey_asymmetricKey (24.12s)
--- PASS: TestAccKMSKey_multiRegion (27.49s)
--- PASS: TestAccKMSKey_basic (27.59s)
--- PASS: TestAccKMSKey_Policy_iamRole (44.76s)
--- PASS: TestAccKMSKey_Policy_basic (45.60s)
--- PASS: TestAccKMSKey_Policy_bypassUpdate (45.69s)
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (53.87s)
--- PASS: TestAccKMSKey_tags (70.64s)
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (76.46s)
--- PASS: TestAccKMSKey_Policy_bypass (152.94s)
--- PASS: TestAccKMSKey_isEnabled (283.55s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kms 287.176s
This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Related #21968
Related #11801
Closes #20665
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):