-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VPC IPAM Service and Update VPC Resources to support IPAM Parameters #21998
Conversation
ipam tests with hardcoded ipams ipam pool barebones working provisioned Create/delete, on hold for finder change pool cidr allocation fix ipv4 regression with advertisable rename provisioned cidrs resource scope resource cidr search fix - temporary catch errors when provisioning and unset from state validate region name using regex rename to vpc rename and add default require primary region on create allocation tags and update waiter rm hardcoded ipam resources cidr deprovision is eventually consistent associate-vpc-cidr ipv4 doc 1st draft fix ValidateFunc for locale update allocation tags get cidr can accept cidr_block filter cidr allocation finder new filter fix disappears situation fix allocation disappears fix provisioning when disappears, nil or deprov update acc tests ipv6 blocked by Associate no impl reorg: ipam reorg: ipam pool reorg - consolidated
457de48
to
2d682a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @drewmullen 🚀
Acceptance test results
--- PASS: TestAccVPC_disappears (92.00s)
--- PASS: TestAccVPC_classicLinkOptionSet (133.81s)
--- PASS: TestAccVPC_basic (135.86s)
--- PASS: TestAccVPC_classicLinkDNSSupportOptionSet (136.38s)
--- PASS: TestAccVPC_bothDNSOptionsSet (150.63s)
--- PASS: TestAccVPC_disabledDNSSupport (154.20s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (31.45s)
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_basic (187.07s)
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (200.24s)
--- PASS: TestAccVPC_update (201.18s)
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (206.66s)
--- PASS: TestAccVPCIpamPoolAllocation_ipv4Basic (207.99s)
--- PASS: TestAccVPC_defaultAndIgnoreTags (219.85s)
--- PASS: TestAccVPC_DefaultTags_providerOnly (263.89s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (264.49s)
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (176.40s)
--- PASS: TestAccVPCIpam_basic (122.64s)
--- PASS: TestAccVPCIpam_tags (276.91s)
--- PASS: TestAccVPC_tags (279.12s)
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (164.53s)
--- PASS: TestAccVPCIpamPool_ipv6Basic (127.14s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (224.38s)
--- PASS: TestAccVPCIpamPoolAllocation_ipv4BasicNetmask (156.98s)
--- PASS: TestAccVPCIpamScope_basic (178.60s)
--- PASS: TestAccVPCIpamPoolCidr_ipv4Basic (160.42s)
--- PASS: TestAccVPCIpam_modifyRegion (232.23s)
--- PASS: TestAccVPCIpamPool_basic (186.85s)
--- PASS: TestAccVPCIpamScope_tags (228.95s)
--- PASS: TestAccVPC_ignoreTags (135.65s)
--- PASS: TestAccVPC_tenancy (160.09s)
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (164.96s)
--- PASS: TestAccVPCIpamPool_tags (245.79s)
This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
for historic purposes - how to test ipv6 byoip:
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #0000
Output from acceptance testing: