Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPC IPAM Service and Update VPC Resources to support IPAM Parameters #21998

Merged
merged 25 commits into from
Dec 2, 2021

Conversation

drewmullen
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. provider Pertains to the provider itself, rather than any interaction with AWS. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Dec 2, 2021
ipam tests with hardcoded ipams

ipam pool barebones working

provisioned Create/delete, on hold for finder change

pool cidr allocation

fix ipv4 regression with advertisable

rename provisioned cidrs resource

scope resource

cidr search fix - temporary

catch errors when provisioning and unset from state

validate region name using regex

rename to vpc

rename and add default

require primary region on create

allocation tags and update waiter

rm hardcoded ipam resources

cidr deprovision is eventually consistent

associate-vpc-cidr ipv4

doc 1st draft

fix ValidateFunc for locale

update allocation tags

get cidr can accept cidr_block filter

cidr allocation finder new filter

fix disappears situation

fix allocation disappears

fix provisioning when disappears, nil or deprov

update acc tests

ipv6 blocked by Associate no impl

reorg: ipam

reorg: ipam pool

reorg - consolidated
@gdavison gdavison self-assigned this Dec 2, 2021
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @drewmullen 🚀

Acceptance test results

--- PASS: TestAccVPC_disappears (92.00s)
--- PASS: TestAccVPC_classicLinkOptionSet (133.81s)
--- PASS: TestAccVPC_basic (135.86s)
--- PASS: TestAccVPC_classicLinkDNSSupportOptionSet (136.38s)
--- PASS: TestAccVPC_bothDNSOptionsSet (150.63s)
--- PASS: TestAccVPC_disabledDNSSupport (154.20s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (31.45s)
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_basic (187.07s)
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (200.24s)
--- PASS: TestAccVPC_update (201.18s)
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (206.66s)
--- PASS: TestAccVPCIpamPoolAllocation_ipv4Basic (207.99s)
--- PASS: TestAccVPC_defaultAndIgnoreTags (219.85s)
--- PASS: TestAccVPC_DefaultTags_providerOnly (263.89s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (264.49s)
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (176.40s)
--- PASS: TestAccVPCIpam_basic (122.64s)
--- PASS: TestAccVPCIpam_tags (276.91s)
--- PASS: TestAccVPC_tags (279.12s)
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (164.53s)
--- PASS: TestAccVPCIpamPool_ipv6Basic (127.14s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (224.38s)
--- PASS: TestAccVPCIpamPoolAllocation_ipv4BasicNetmask (156.98s)
--- PASS: TestAccVPCIpamScope_basic (178.60s)
--- PASS: TestAccVPCIpamPoolCidr_ipv4Basic (160.42s)
--- PASS: TestAccVPCIpam_modifyRegion (232.23s)
--- PASS: TestAccVPCIpamPool_basic (186.85s)
--- PASS: TestAccVPCIpamScope_tags (228.95s)
--- PASS: TestAccVPC_ignoreTags (135.65s)
--- PASS: TestAccVPC_tenancy (160.09s)
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (164.96s)
--- PASS: TestAccVPCIpamPool_tags (245.79s)

@gdavison gdavison merged commit 2827e28 into hashicorp:main Dec 2, 2021
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Dec 2, 2021
@github-actions github-actions bot added this to the v3.68.0 milestone Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@drewmullen
Copy link
Collaborator Author

for historic purposes - how to test ipv6 byoip:

$ export IPAM_BYOIP_IPV6_MESSAGE=<>
$ export IPAM_BYOIP_IPV6_SIGNATURE=<>
$ export IPAM_BYOIP_IPV6_PROVISIONED_CIDR="<>:<>:407::/48"
$ export IPAM_BYOIP_IPV6_EXPLICIT_CIDR_VPC="<>:<>:407:800::/56"
$ export IPAM_BYOIP_IPV6_EXPLICIT_CIDR_ASSOCIATE="<>:>?:407:b00::/56"

$ make testacc TESTARGS='-run=TestAccVPCIpam_ByoipIPv6' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCIpam_ByoipIPv6 -timeout 180m
=== RUN   TestAccVPCIpam_ByoipIPv6
=== PAUSE TestAccVPCIpam_ByoipIPv6
=== CONT  TestAccVPCIpam_ByoipIPv6
--- PASS: TestAccVPCIpam_ByoipIPv6 (1423.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1426.656s

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants