-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apigateway/rest_api: Fix diffs from equivalent policies #22115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAPIGatewayRestAPI PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayRestAPI' -timeout 180m
=== RUN TestAccAPIGatewayRestAPIDataSource_basic
=== PAUSE TestAccAPIGatewayRestAPIDataSource_basic
=== RUN TestAccAPIGatewayRestAPIDataSource_Endpoint_vpcEndpointIDs
=== PAUSE TestAccAPIGatewayRestAPIDataSource_Endpoint_vpcEndpointIDs
=== RUN TestAccAPIGatewayRestAPIPolicy_basic
=== PAUSE TestAccAPIGatewayRestAPIPolicy_basic
=== RUN TestAccAPIGatewayRestAPIPolicy_disappears
=== PAUSE TestAccAPIGatewayRestAPIPolicy_disappears
=== RUN TestAccAPIGatewayRestAPIPolicy_Disappears_restAPI
=== PAUSE TestAccAPIGatewayRestAPIPolicy_Disappears_restAPI
=== RUN TestAccAPIGatewayRestAPI_basic
=== PAUSE TestAccAPIGatewayRestAPI_basic
=== RUN TestAccAPIGatewayRestAPI_tags
=== PAUSE TestAccAPIGatewayRestAPI_tags
=== RUN TestAccAPIGatewayRestAPI_disappears
=== PAUSE TestAccAPIGatewayRestAPI_disappears
=== RUN TestAccAPIGatewayRestAPI_endpoint
=== PAUSE TestAccAPIGatewayRestAPI_endpoint
=== RUN TestAccAPIGatewayRestAPI_Endpoint_private
=== PAUSE TestAccAPIGatewayRestAPI_Endpoint_private
=== RUN TestAccAPIGatewayRestAPI_apiKeySource
=== PAUSE TestAccAPIGatewayRestAPI_apiKeySource
=== RUN TestAccAPIGatewayRestAPI_APIKeySource_overrideBody
=== PAUSE TestAccAPIGatewayRestAPI_APIKeySource_overrideBody
=== RUN TestAccAPIGatewayRestAPI_APIKeySource_setByBody
=== PAUSE TestAccAPIGatewayRestAPI_APIKeySource_setByBody
=== RUN TestAccAPIGatewayRestAPI_binaryMediaTypes
=== PAUSE TestAccAPIGatewayRestAPI_binaryMediaTypes
=== RUN TestAccAPIGatewayRestAPI_BinaryMediaTypes_overrideBody
=== PAUSE TestAccAPIGatewayRestAPI_BinaryMediaTypes_overrideBody
=== RUN TestAccAPIGatewayRestAPI_BinaryMediaTypes_setByBody
=== PAUSE TestAccAPIGatewayRestAPI_BinaryMediaTypes_setByBody
=== RUN TestAccAPIGatewayRestAPI_body
=== PAUSE TestAccAPIGatewayRestAPI_body
=== RUN TestAccAPIGatewayRestAPI_description
=== PAUSE TestAccAPIGatewayRestAPI_description
=== RUN TestAccAPIGatewayRestAPI_Description_overrideBody
=== PAUSE TestAccAPIGatewayRestAPI_Description_overrideBody
=== RUN TestAccAPIGatewayRestAPI_Description_setByBody
=== PAUSE TestAccAPIGatewayRestAPI_Description_setByBody
=== RUN TestAccAPIGatewayRestAPI_disableExecuteAPIEndpoint
=== PAUSE TestAccAPIGatewayRestAPI_disableExecuteAPIEndpoint
=== RUN TestAccAPIGatewayRestAPI_DisableExecuteAPIEndpoint_overrideBody
=== PAUSE TestAccAPIGatewayRestAPI_DisableExecuteAPIEndpoint_overrideBody
=== RUN TestAccAPIGatewayRestAPI_DisableExecuteAPIEndpoint_setByBody
=== PAUSE TestAccAPIGatewayRestAPI_DisableExecuteAPIEndpoint_setByBody
=== RUN TestAccAPIGatewayRestAPI_Endpoint_vpcEndpointIDs
=== PAUSE TestAccAPIGatewayRestAPI_Endpoint_vpcEndpointIDs
=== RUN TestAccAPIGatewayRestAPI_EndpointVPCEndpointIDs_overrideBody
=== PAUSE TestAccAPIGatewayRestAPI_EndpointVPCEndpointIDs_overrideBody
=== RUN TestAccAPIGatewayRestAPI_EndpointVPCEndpointIDs_setByBody
=== PAUSE TestAccAPIGatewayRestAPI_EndpointVPCEndpointIDs_setByBody
=== RUN TestAccAPIGatewayRestAPI_minimumCompressionSize
=== PAUSE TestAccAPIGatewayRestAPI_minimumCompressionSize
=== RUN TestAccAPIGatewayRestAPI_MinimumCompressionSize_overrideBody
=== PAUSE TestAccAPIGatewayRestAPI_MinimumCompressionSize_overrideBody
=== RUN TestAccAPIGatewayRestAPI_MinimumCompressionSize_setByBody
=== PAUSE TestAccAPIGatewayRestAPI_MinimumCompressionSize_setByBody
=== RUN TestAccAPIGatewayRestAPI_Name_overrideBody
=== PAUSE TestAccAPIGatewayRestAPI_Name_overrideBody
=== RUN TestAccAPIGatewayRestAPI_parameters
=== PAUSE TestAccAPIGatewayRestAPI_parameters
=== RUN TestAccAPIGatewayRestAPI_Policy_basic
=== PAUSE TestAccAPIGatewayRestAPI_Policy_basic
=== RUN TestAccAPIGatewayRestAPI_Policy_order
=== PAUSE TestAccAPIGatewayRestAPI_Policy_order
=== RUN TestAccAPIGatewayRestAPI_Policy_overrideBody
=== PAUSE TestAccAPIGatewayRestAPI_Policy_overrideBody
=== RUN TestAccAPIGatewayRestAPI_Policy_setByBody
=== PAUSE TestAccAPIGatewayRestAPI_Policy_setByBody
=== CONT TestAccAPIGatewayRestAPI_Endpoint_vpcEndpointIDs
=== CONT TestAccAPIGatewayRestAPI_body
=== CONT TestAccAPIGatewayRestAPI_BinaryMediaTypes_setByBody
=== CONT TestAccAPIGatewayRestAPIDataSource_basic
=== CONT TestAccAPIGatewayRestAPI_APIKeySource_overrideBody
=== CONT TestAccAPIGatewayRestAPI_apiKeySource
=== CONT TestAccAPIGatewayRestAPI_Endpoint_private
=== CONT TestAccAPIGatewayRestAPI_endpoint
=== CONT TestAccAPIGatewayRestAPI_disappears
=== CONT TestAccAPIGatewayRestAPI_tags
=== CONT TestAccAPIGatewayRestAPI_basic
=== CONT TestAccAPIGatewayRestAPIPolicy_Disappears_restAPI
=== CONT TestAccAPIGatewayRestAPIPolicy_disappears
=== CONT TestAccAPIGatewayRestAPIPolicy_basic
=== CONT TestAccAPIGatewayRestAPI_APIKeySource_setByBody
=== CONT TestAccAPIGatewayRestAPI_description
=== CONT TestAccAPIGatewayRestAPIDataSource_Endpoint_vpcEndpointIDs
=== CONT TestAccAPIGatewayRestAPI_Description_overrideBody
=== CONT TestAccAPIGatewayRestAPI_DisableExecuteAPIEndpoint_setByBody
=== CONT TestAccAPIGatewayRestAPI_DisableExecuteAPIEndpoint_overrideBody
--- PASS: TestAccAPIGatewayRestAPI_disappears (32.31s)
=== CONT TestAccAPIGatewayRestAPI_disableExecuteAPIEndpoint
--- PASS: TestAccAPIGatewayRestAPI_BinaryMediaTypes_setByBody (57.77s)
=== CONT TestAccAPIGatewayRestAPI_Description_setByBody
--- PASS: TestAccAPIGatewayRestAPI_Endpoint_private (67.79s)
=== CONT TestAccAPIGatewayRestAPI_parameters
--- PASS: TestAccAPIGatewayRestAPIPolicy_Disappears_restAPI (100.85s)
=== CONT TestAccAPIGatewayRestAPI_BinaryMediaTypes_overrideBody
--- PASS: TestAccAPIGatewayRestAPI_disableExecuteAPIEndpoint (85.84s)
=== CONT TestAccAPIGatewayRestAPI_MinimumCompressionSize_overrideBody
--- PASS: TestAccAPIGatewayRestAPI_APIKeySource_overrideBody (138.43s)
=== CONT TestAccAPIGatewayRestAPI_Name_overrideBody
--- PASS: TestAccAPIGatewayRestAPI_MinimumCompressionSize_overrideBody (59.34s)
=== CONT TestAccAPIGatewayRestAPI_Policy_setByBody
--- PASS: TestAccAPIGatewayRestAPI_Policy_setByBody (33.40s)
=== CONT TestAccAPIGatewayRestAPI_Policy_overrideBody
--- PASS: TestAccAPIGatewayRestAPIDataSource_Endpoint_vpcEndpointIDs (216.83s)
=== CONT TestAccAPIGatewayRestAPI_Policy_order
--- PASS: TestAccAPIGatewayRestAPI_DisableExecuteAPIEndpoint_overrideBody (239.67s)
=== CONT TestAccAPIGatewayRestAPI_Policy_basic
--- PASS: TestAccAPIGatewayRestAPI_Policy_overrideBody (49.92s)
=== CONT TestAccAPIGatewayRestAPI_binaryMediaTypes
--- PASS: TestAccAPIGatewayRestAPI_tags (308.50s)
=== CONT TestAccAPIGatewayRestAPI_EndpointVPCEndpointIDs_setByBody
--- PASS: TestAccAPIGatewayRestAPI_Description_setByBody (250.78s)
=== CONT TestAccAPIGatewayRestAPI_minimumCompressionSize
--- PASS: TestAccAPIGatewayRestAPI_minimumCompressionSize (44.91s)
=== CONT TestAccAPIGatewayRestAPI_EndpointVPCEndpointIDs_overrideBody
--- PASS: TestAccAPIGatewayRestAPIDataSource_basic (423.66s)
=== CONT TestAccAPIGatewayRestAPI_MinimumCompressionSize_setByBody
--- PASS: TestAccAPIGatewayRestAPIPolicy_disappears (428.20s)
--- PASS: TestAccAPIGatewayRestAPI_MinimumCompressionSize_setByBody (21.39s)
--- PASS: TestAccAPIGatewayRestAPI_Endpoint_vpcEndpointIDs (455.34s)
--- PASS: TestAccAPIGatewayRestAPI_body (498.94s)
--- PASS: TestAccAPIGatewayRestAPI_EndpointVPCEndpointIDs_setByBody (217.52s)
--- PASS: TestAccAPIGatewayRestAPI_Name_overrideBody (390.54s)
--- PASS: TestAccAPIGatewayRestAPI_Description_overrideBody (557.48s)
--- PASS: TestAccAPIGatewayRestAPI_description (604.77s)
--- PASS: TestAccAPIGatewayRestAPI_binaryMediaTypes (370.40s)
--- PASS: TestAccAPIGatewayRestAPI_Policy_order (466.29s)
--- PASS: TestAccAPIGatewayRestAPI_EndpointVPCEndpointIDs_overrideBody (333.87s)
--- PASS: TestAccAPIGatewayRestAPI_APIKeySource_setByBody (699.34s)
--- PASS: TestAccAPIGatewayRestAPI_apiKeySource (729.38s)
--- PASS: TestAccAPIGatewayRestAPI_parameters (711.38s)
--- PASS: TestAccAPIGatewayRestAPI_basic (814.09s)
--- PASS: TestAccAPIGatewayRestAPI_BinaryMediaTypes_overrideBody (808.74s)
--- PASS: TestAccAPIGatewayRestAPI_Policy_basic (732.38s)
--- PASS: TestAccAPIGatewayRestAPI_DisableExecuteAPIEndpoint_setByBody (978.45s)
--- PASS: TestAccAPIGatewayRestAPIPolicy_basic (1057.79s)
--- PASS: TestAccAPIGatewayRestAPI_endpoint (1153.25s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 1158.595s
This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #21968
Output from acceptance testing: