Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Service Catalog resource 'aws_servicecatalog_accept_portfolio_share' #22503

Open
bschaatsbergen opened this issue Jan 10, 2022 · 3 comments
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/servicecatalog Issues and PRs that pertain to the servicecatalog service.

Comments

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Jan 10, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

To import a service catalog portfolio you'll need to make use of the AcceptPortfolioShare API from the Service Catalog. At the moment this is not supported through our Terraform AWS provider (from what I can see, please correct me if I'm wrong).

API Reference: https://docs.aws.amazon.com/servicecatalog/latest/dg/API_AcceptPortfolioShare.html#servicecatalog-AcceptPortfolioShare-request-PortfolioShareType

There's a CloudFormation resource available too which does not list the PortfolioShareType property, https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-servicecatalog-acceptedportfolioshare.html
any idea?

New or Affected Resource(s)

  • aws_servicecatalog_accept_portfolio_share

Potential Terraform Configuration

resource "aws_servicecatalog_accept_portfolio_share" "example" {
  accept_language = "en"
  portfolio_id = "prod-dnigbtea24ste"
  portfolio_share_type = "aws_organizations"
}

References

@bschaatsbergen bschaatsbergen added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 10, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. labels Jan 10, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 11, 2022
@adrianbahja01
Copy link

adrianbahja01 commented Feb 14, 2024

I think this needs to be prioritized a bit :). It is a missing piece which stops the terraform to automate the whole process. @bschaatsbergen do you have any update on this or any workarounds?

@bschaatsbergen
Copy link
Member Author

I'll happily work on it actually, I noticed the same 2 years ago! @adrianbahja01

Give me a week or two and it's finished 😎

@bschaatsbergen bschaatsbergen self-assigned this Feb 14, 2024
@bschaatsbergen
Copy link
Member Author

Prior to implementing this I would like to finish some existing tech-debt (migrating to the v2 AWS SDK): #36009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/servicecatalog Issues and PRs that pertain to the servicecatalog service.
Projects
None yet
Development

No branches or pull requests

3 participants