Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_connect_security_profile-read new attribute #22761

Merged
merged 6 commits into from
Feb 28, 2022
Merged

r/aws_connect_security_profile-read new attribute #22761

merged 6 commits into from
Feb 28, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Jan 26, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22847

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectSecurityProfile_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectSecurityProfile_serial'  -timeout 180m
=== RUN   TestAccConnectSecurityProfile_serial
=== RUN   TestAccConnectSecurityProfile_serial/basic
=== RUN   TestAccConnectSecurityProfile_serial/disappears
=== RUN   TestAccConnectSecurityProfile_serial/update_permissions
--- PASS: TestAccConnectSecurityProfile_serial (477.90s)
    --- PASS: TestAccConnectSecurityProfile_serial/basic (212.92s)
    --- PASS: TestAccConnectSecurityProfile_serial/disappears (108.76s)
    --- PASS: TestAccConnectSecurityProfile_serial/update_permissions (156.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    485.724s

...

Notes

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jan 26, 2022
@GlennChia
Copy link
Collaborator Author

Re-ran test case after latest change

$ make testacc TESTS=TestAccConnectSecurityProfile_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectSecurityProfile_serial'  -timeout 180m
=== RUN   TestAccConnectSecurityProfile_serial
=== RUN   TestAccConnectSecurityProfile_serial/update_permissions
=== RUN   TestAccConnectSecurityProfile_serial/basic
=== RUN   TestAccConnectSecurityProfile_serial/disappears
--- PASS: TestAccConnectSecurityProfile_serial (525.14s)
    --- PASS: TestAccConnectSecurityProfile_serial/update_permissions (210.10s)
    --- PASS: TestAccConnectSecurityProfile_serial/basic (185.53s)
    --- PASS: TestAccConnectSecurityProfile_serial/disappears (129.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    533.123s

@GlennChia GlennChia mentioned this pull request Jan 31, 2022
Closed
AdamTylerLynch
AdamTylerLynch approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

AdamTylerLynch
AdamTylerLynch approved these changes Feb 4, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

AdamTylerLynch
AdamTylerLynch approved these changes Feb 4, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 16, 2022
@breathingdust
Copy link
Member

LGTM 🚀 ! Thanks @GlennChia!

Validated Acceptance Tests in Commercial (us-west-2)

make testacc TESTS=TestAccConnectSecurityProfile_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectSecurityProfile_serial'  -timeout 180m
=== RUN   TestAccConnectSecurityProfile_serial
=== RUN   TestAccConnectSecurityProfile_serial/basic
=== RUN   TestAccConnectSecurityProfile_serial/disappears
=== RUN   TestAccConnectSecurityProfile_serial/update_permissions
--- PASS: TestAccConnectSecurityProfile_serial (295.00s)
    --- PASS: TestAccConnectSecurityProfile_serial/basic (102.87s)
    --- PASS: TestAccConnectSecurityProfile_serial/disappears (83.45s)
    --- PASS: TestAccConnectSecurityProfile_serial/update_permissions (108.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	298.417s

Validated Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTS=TestAccConnectSecurityProfile_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectSecurityProfile_serial'  -timeout 180m
=== RUN   TestAccConnectSecurityProfile_serial
=== RUN   TestAccConnectSecurityProfile_serial/basic
=== RUN   TestAccConnectSecurityProfile_serial/disappears
=== RUN   TestAccConnectSecurityProfile_serial/update_permissions
--- PASS: TestAccConnectSecurityProfile_serial (255.40s)
    --- PASS: TestAccConnectSecurityProfile_serial/basic (84.95s)
    --- PASS: TestAccConnectSecurityProfile_serial/disappears (89.28s)
    --- PASS: TestAccConnectSecurityProfile_serial/update_permissions (81.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	258.641s

@breathingdust breathingdust merged commit 95d0ba1 into hashicorp:main Feb 28, 2022
@github-actions github-actions bot added this to the v4.3.0 milestone Feb 28, 2022
@GlennChia GlennChia deleted the f-aws_connect_security_profile-read-new-attribute branch February 28, 2022 16:59
YakDriver pushed a commit that referenced this pull request Feb 28, 2022
@GlennChia @YakDriver
r/aws_connect_security_profile-read new attribute (#22761)
dcec6f9 
* chore(connect): fix comment typo for max results

* feat(connect): add read for permissions attribute

* test(connect): basic sec profile with no perm

length should be 0 since empty list is returned

* test(connect): sec profile permissions update

test updating of permissions from original 0 to 2 new permissions

* ci(connect): changelog for permissions attribute

* test(connect): rm ImportStateVerifyIgnore for perm
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

@YakDriver YakDriver Awaiting requested review from YakDriver

@gdavison gdavison Awaiting requested review from gdavison

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/connect Issues and PRs that pertain to the connect service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.

Add read support for permissions attribute for aws_connect_security_profile resource
4 participants
@GlennChia @breathingdust @AdamTylerLynch @justinretzolk