-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/dataexchanage_revision - new resource #22933
r/dataexchanage_revision - new resource #22933
Conversation
a6f2a61
to
0c39dd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTS=TestAccDataExchangeRevision_ PKG=dataexchange
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeRevision_' -timeout 180m
=== RUN TestAccDataExchangeRevision_basic
=== PAUSE TestAccDataExchangeRevision_basic
=== RUN TestAccDataExchangeRevision_tags
=== PAUSE TestAccDataExchangeRevision_tags
=== RUN TestAccDataExchangeRevision_disappears
=== PAUSE TestAccDataExchangeRevision_disappears
=== RUN TestAccDataExchangeRevision_disappears_dataSet
=== PAUSE TestAccDataExchangeRevision_disappears_dataSet
=== CONT TestAccDataExchangeRevision_basic
=== CONT TestAccDataExchangeRevision_disappears
=== CONT TestAccDataExchangeRevision_tags
=== CONT TestAccDataExchangeRevision_disappears_dataSet
--- PASS: TestAccDataExchangeRevision_disappears_dataSet (17.42s)
--- PASS: TestAccDataExchangeRevision_basic (20.76s)
--- PASS: TestAccDataExchangeRevision_disappears (21.72s)
--- PASS: TestAccDataExchangeRevision_tags (53.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange 56.774s
GovCloud
% make testacc TESTS=TestAccDataExchangeRevision_ PKG=dataexchange
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeRevision_' -timeout 180m
=== RUN TestAccDataExchangeRevision_basic
=== PAUSE TestAccDataExchangeRevision_basic
=== RUN TestAccDataExchangeRevision_tags
=== PAUSE TestAccDataExchangeRevision_tags
=== RUN TestAccDataExchangeRevision_disappears
=== PAUSE TestAccDataExchangeRevision_disappears
=== RUN TestAccDataExchangeRevision_disappears_dataSet
=== PAUSE TestAccDataExchangeRevision_disappears_dataSet
=== CONT TestAccDataExchangeRevision_basic
=== CONT TestAccDataExchangeRevision_disappears
=== CONT TestAccDataExchangeRevision_tags
=== CONT TestAccDataExchangeRevision_disappears_dataSet
=== CONT TestAccDataExchangeRevision_basic
acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
=== CONT TestAccDataExchangeRevision_disappears
acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
=== CONT TestAccDataExchangeRevision_disappears_dataSet
acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
--- SKIP: TestAccDataExchangeRevision_basic (1.41s)
--- SKIP: TestAccDataExchangeRevision_disappears (1.41s)
=== CONT TestAccDataExchangeRevision_tags
acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
--- SKIP: TestAccDataExchangeRevision_disappears_dataSet (1.41s)
--- SKIP: TestAccDataExchangeRevision_tags (1.41s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange 4.932s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #22237
Output from acceptance testing: