Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_guardduty_detector: Kubernetes events with GuardDuty #22987

Closed
parente opened this issue Feb 7, 2022 · 7 comments · Fixed by #22859
Closed

resource/aws_guardduty_detector: Kubernetes events with GuardDuty #22987

parente opened this issue Feb 7, 2022 · 7 comments · Fixed by #22859
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Milestone

Comments

@parente
Copy link

parente commented Feb 7, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

GuardDuty now supports Elastic Kubernetes Service (EKS) audit log monitoring. Can the aws_guardduty_detector resource support a boolean switch to turn it on / off like it does for S3?

New or Affected Resource(s)

  • aws_guardduty_detector

Potential Terraform Configuration

resource "aws_guardduty_detector" "my_detector" {
  enable = true

  datasources {
    s3_logs {
      enable = true
    }
    eks_logs {
      enable = true
    }
  }
}

References

@parente parente added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 7, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/guardduty Issues and PRs that pertain to the guardduty service. labels Feb 7, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 7, 2022
@mkmqsec
Copy link

mkmqsec commented Feb 9, 2022

I think this change would also affect the aws_guardduty_organization_configuration resource as well.

@robbie-daniels
Copy link

I think this change would also affect the aws_guardduty_organization_configuration resource as well.

Yeah, I think there would be a counterpart to the s3_logs datasource field

@mathewmoon
Copy link

Absolutely. I see this more as an important bug.

@woz5999
Copy link
Contributor

woz5999 commented May 25, 2022

any progress on this?

@danh-git
Copy link

danh-git commented Jun 1, 2022

Any update please?

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants