Add aws_mskconnect_connector resource #23544

gungoren · 2022-03-07T11:54:31Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20942.
Relates #21073.
Similar #22919.
Closes #22682.

Output from acceptance testing:

$ make testacc TESTS=TestAccKafkaConnectConnector PKG=kafkaconnect

...

github-actions · 2022-03-07T11:55:00Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

github-actions

Welcome @gungoren 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

This reverts commit dfcbf8c.

This reverts commit 9a8f5aa.

This reverts commit b4fac0a.

This reverts commit 8c6a425.

…r signatures (#15090).

Acceptance test output: % make testacc TESTS=TestAccKafkaConnectCustomPlugin_ PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectCustomPlugin_' -timeout 180m === RUN TestAccKafkaConnectCustomPlugin_basic === PAUSE TestAccKafkaConnectCustomPlugin_basic === RUN TestAccKafkaConnectCustomPlugin_description === PAUSE TestAccKafkaConnectCustomPlugin_description === RUN TestAccKafkaConnectCustomPlugin_contentType === PAUSE TestAccKafkaConnectCustomPlugin_contentType === RUN TestAccKafkaConnectCustomPlugin_objectVersion === PAUSE TestAccKafkaConnectCustomPlugin_objectVersion === CONT TestAccKafkaConnectCustomPlugin_basic === CONT TestAccKafkaConnectCustomPlugin_contentType --- PASS: TestAccKafkaConnectCustomPlugin_basic (41.38s) === CONT TestAccKafkaConnectCustomPlugin_description --- PASS: TestAccKafkaConnectCustomPlugin_contentType (68.96s) === CONT TestAccKafkaConnectCustomPlugin_objectVersion --- PASS: TestAccKafkaConnectCustomPlugin_description (29.53s) --- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (29.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 102.677s

…ions. Acceptance test output: % make testacc TESTS=TestAccKafkaConnectCustomPlugin PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectCustomPlugin' -timeout 180m === RUN TestAccKafkaConnectCustomPluginDataSource_basic === PAUSE TestAccKafkaConnectCustomPluginDataSource_basic === RUN TestAccKafkaConnectCustomPlugin_basic === PAUSE TestAccKafkaConnectCustomPlugin_basic === RUN TestAccKafkaConnectCustomPlugin_description === PAUSE TestAccKafkaConnectCustomPlugin_description === RUN TestAccKafkaConnectCustomPlugin_objectVersion === PAUSE TestAccKafkaConnectCustomPlugin_objectVersion === CONT TestAccKafkaConnectCustomPluginDataSource_basic === CONT TestAccKafkaConnectCustomPlugin_description --- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (87.75s) === CONT TestAccKafkaConnectCustomPlugin_objectVersion --- PASS: TestAccKafkaConnectCustomPlugin_description (89.30s) === CONT TestAccKafkaConnectCustomPlugin_basic --- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (47.41s) --- PASS: TestAccKafkaConnectCustomPlugin_basic (47.08s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 142.592s

Acceptance test output: % AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccKafkaConnectConnector_ PKG=kafkaconnect ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run='TestAccKafkaConnectConnector_' -timeout 180m === RUN TestAccKafkaConnectConnector_basic === PAUSE TestAccKafkaConnectConnector_basic === CONT TestAccKafkaConnectConnector_basic --- PASS: TestAccKafkaConnectConnector_basic (1877.87s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 1881.927s

…disappears'. Acceptance test output: % make testacc TESTS=TestAccKafkaConnectCustomPlugin PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectCustomPlugin' -timeout 180m === RUN TestAccKafkaConnectCustomPluginDataSource_basic === PAUSE TestAccKafkaConnectCustomPluginDataSource_basic === RUN TestAccKafkaConnectCustomPlugin_basic === PAUSE TestAccKafkaConnectCustomPlugin_basic === RUN TestAccKafkaConnectCustomPlugin_disappears === PAUSE TestAccKafkaConnectCustomPlugin_disappears === RUN TestAccKafkaConnectCustomPlugin_description === PAUSE TestAccKafkaConnectCustomPlugin_description === RUN TestAccKafkaConnectCustomPlugin_objectVersion === PAUSE TestAccKafkaConnectCustomPlugin_objectVersion === CONT TestAccKafkaConnectCustomPluginDataSource_basic === CONT TestAccKafkaConnectCustomPlugin_description --- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (42.15s) === CONT TestAccKafkaConnectCustomPlugin_disappears --- PASS: TestAccKafkaConnectCustomPlugin_description (49.43s) === CONT TestAccKafkaConnectCustomPlugin_basic --- PASS: TestAccKafkaConnectCustomPlugin_disappears (41.17s) === CONT TestAccKafkaConnectCustomPlugin_objectVersion --- PASS: TestAccKafkaConnectCustomPlugin_basic (41.36s) --- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (40.76s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 128.293s

…RUD handler signatures (#15090). Acceptance test output: % make testacc TESTS=TestAccKafkaConnectWorkerConfiguration PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectWorkerConfiguration' -timeout 180m === RUN TestAccKafkaConnectWorkerConfigurationDataSource_basic === PAUSE TestAccKafkaConnectWorkerConfigurationDataSource_basic === RUN TestAccKafkaConnectWorkerConfiguration_basic === PAUSE TestAccKafkaConnectWorkerConfiguration_basic === RUN TestAccKafkaConnectWorkerConfiguration_description === PAUSE TestAccKafkaConnectWorkerConfiguration_description === CONT TestAccKafkaConnectWorkerConfigurationDataSource_basic === CONT TestAccKafkaConnectWorkerConfiguration_description --- PASS: TestAccKafkaConnectWorkerConfiguration_description (18.52s) === CONT TestAccKafkaConnectWorkerConfiguration_basic --- PASS: TestAccKafkaConnectWorkerConfigurationDataSource_basic (22.36s) --- PASS: TestAccKafkaConnectWorkerConfiguration_basic (16.57s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 39.258s

…ars' and 'TestAccKafkaConnectConnector_update'. Acceptance test output: % AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccKafkaConnectConnector PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectConnector' -timeout 180m === RUN TestAccKafkaConnectConnectorDataSource_basic === PAUSE TestAccKafkaConnectConnectorDataSource_basic === RUN TestAccKafkaConnectConnector_basic === PAUSE TestAccKafkaConnectConnector_basic === RUN TestAccKafkaConnectConnector_disappears === PAUSE TestAccKafkaConnectConnector_disappears === RUN TestAccKafkaConnectConnector_update === PAUSE TestAccKafkaConnectConnector_update === CONT TestAccKafkaConnectConnectorDataSource_basic === CONT TestAccKafkaConnectConnector_disappears --- PASS: TestAccKafkaConnectConnector_disappears (2211.69s) === CONT TestAccKafkaConnectConnector_basic --- PASS: TestAccKafkaConnectConnectorDataSource_basic (2211.72s) === CONT TestAccKafkaConnectConnector_update --- PASS: TestAccKafkaConnectConnector_update (2762.06s) --- PASS: TestAccKafkaConnectConnector_basic (2541.67s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 4760.897s

ewbankkit

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccKafkaConnectConnector PKG=kafkaconnect ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectConnector'  -timeout 180m
=== RUN   TestAccKafkaConnectConnectorDataSource_basic
=== PAUSE TestAccKafkaConnectConnectorDataSource_basic
=== RUN   TestAccKafkaConnectConnector_basic
=== PAUSE TestAccKafkaConnectConnector_basic
=== RUN   TestAccKafkaConnectConnector_disappears
=== PAUSE TestAccKafkaConnectConnector_disappears
=== RUN   TestAccKafkaConnectConnector_update
=== PAUSE TestAccKafkaConnectConnector_update
=== CONT  TestAccKafkaConnectConnectorDataSource_basic
=== CONT  TestAccKafkaConnectConnector_disappears
--- PASS: TestAccKafkaConnectConnector_disappears (2211.69s)
=== CONT  TestAccKafkaConnectConnector_basic
--- PASS: TestAccKafkaConnectConnectorDataSource_basic (2211.72s)
=== CONT  TestAccKafkaConnectConnector_update
--- PASS: TestAccKafkaConnectConnector_update (2762.06s)
--- PASS: TestAccKafkaConnectConnector_basic (2541.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	4760.897s

ewbankkit · 2022-03-25T10:16:19Z

@gungoren Thanks for the contribution 🎉 👏.

github-actions · 2022-03-27T12:13:01Z

This functionality has been released in v4.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-05T02:31:00Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

rtim75 and others added 7 commits January 31, 2022 14:18

create and delete methods

8c6a425

finish log delivery

b4fac0a

small refactoring

9a8f5aa

add worker configuration

dfcbf8c

implement kafkaconnect connector resource

c731a38

merge master

ef77fe1

Merge branch 'hashicorp-main'

a586acd

gungoren added 2 commits March 7, 2022 15:00

remove go.mod go.sum changes prevent conflict with dependabot

ef0aa2a

go.mod changes

40a6e98

github-actions bot reviewed Mar 7, 2022

View reviewed changes

gungoren added 5 commits March 7, 2022 15:23

fix worklow errors

da023c2

fix worklow errors

080e8e9

fix worklow errors

1c0af09

fix worklow errors

a07b0a9

add docs for mskconnect_connector

1f015c1

github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 7, 2022

ewbankkit added 5 commits March 21, 2022 09:23

Revert "add worker configuration"

777a310

This reverts commit dfcbf8c.

Revert "small refactoring"

68195ed

This reverts commit 9a8f5aa.

Revert "finish log delivery"

220a076

This reverts commit b4fac0a.

Revert "create and delete methods"

5e8fd59

This reverts commit 8c6a425.

Merge commit '5e8fd596e03bf7abb40474966d05a8a374e19da3' into HEAD

122d4cb

ewbankkit mentioned this pull request Mar 21, 2022

Add aws_mskconnect_connector resource #22919

Closed

Use 'github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr'.

c05b17a

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2022

GuiBolson approved these changes Mar 21, 2022

View reviewed changes

fabriciomariani approved these changes Mar 22, 2022

View reviewed changes

ewbankkit added 7 commits March 22, 2022 13:43

Sweep MSK Connect resources.

b53275d

r/aws_mskconnect_custom_plugin: Migrate to WithoutTimeout CRUD handle…

aba5cb8

…r signatures (#15090).

Add CHANGELOG entry.

3f16cb0

Correct package for sweeper.

7950205

Sweep MSK Connect Connectors before MSK Clusters.

3685750

Use an MSK cluster in MSK Connect Connector tests.

22017c1

github-actions bot added service/kafka Issues and PRs that pertain to the kafka service. sweeper Pertains to changes to or issues with the sweeper. labels Mar 23, 2022

ewbankkit and others added 9 commits March 23, 2022 08:03

Merge branch 'main' into HEAD

1ae5d93

remove unused test method - fixes golangci

485a3ad

r/aws_mskconnect_connector: Increase default Create and Update timeouts.

f5e41a8

Complete documentation.

8080900

ewbankkit changed the title ~~[WIP] Add aws_mskconnect_connector resource~~ Add aws_mskconnect_connector resource Mar 25, 2022

ewbankkit approved these changes Mar 25, 2022

View reviewed changes

ewbankkit merged commit d92876f into hashicorp:main Mar 25, 2022

github-actions bot added this to the v4.8.0 milestone Mar 25, 2022

bryantbiggs mentioned this pull request Mar 26, 2022

Unable to update aws_mskconnect_custom_plugin #22481

Closed

ewbankkit mentioned this pull request Mar 27, 2022

fix changelog entry for aws_mskconnect_connector resource #23886

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add aws_mskconnect_connector resource #23544

Add aws_mskconnect_connector resource #23544

gungoren commented Mar 7, 2022 •

edited by ewbankkit

Loading

github-actions bot commented Mar 7, 2022

github-actions bot left a comment

ewbankkit left a comment

ewbankkit commented Mar 25, 2022

github-actions bot commented Mar 27, 2022

github-actions bot commented May 5, 2022

Add aws_mskconnect_connector resource #23544

Add aws_mskconnect_connector resource #23544

Conversation

gungoren commented Mar 7, 2022 • edited by ewbankkit Loading

Community Note

github-actions bot commented Mar 7, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Mar 25, 2022

github-actions bot commented Mar 27, 2022

github-actions bot commented May 5, 2022

gungoren commented Mar 7, 2022 •

edited by ewbankkit

Loading