add enable flag for aws_s3_bucket_versioning

[mheiges]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The versioning block of the aws_s3_bucket resource in the 3.x provider used a boolean enabled flag. If false, the bucket would be transparently managed either as unversioned or versioned-suspended as needed to satisfy AWS rules.

The new aws_s3_bucket_versioning has to be explicitly defined as Disabled or Suspended when we don't want versioning enabled. This requires that we now micro-manage individual buckets because some random buckets that were originally created as enabled = false (unversioned) may have been manually changed to Suspended outside Terraform, say through the S3 console. Those buckets become incompatible with the "Disabled" setting in Terraform. We have a long list of buckets, created by a single module, that we now have to individually parameterize with Disable or Suspended unless we force everything to Suspended.

Can a boolean enable flag be added to aws_s3_bucket_versioning that restores the transparent management of unversioned/suspended states?

New or Affected Resource(s)

• aws_s3_bucket_versioning

Potential Terraform Configuration

resource "aws_s3_bucket_versioning" "example" {
  bucket = aws_s3_bucket.example.id
  versioning_configuration {
    enabled = false
  }
}

[casey-robertson-paypal]

Seeing this same issue. Was working through provider upgrade and ran into the following. I cannot account for why the status is Suspended vs Disabled but it is and now I can't run the 4.x provider against it.

╷
│ Error: versioning_configuration.status cannot be updated from 'Suspended' to 'Disabled'
│ 

Resource:

resource "aws_s3_bucket_versioning" "xxxxx_qrcode_bucket" {
  bucket = aws_s3_bucket.xxxxx_qrcode_bucket.id
  versioning_configuration {
    status = "Disabled"
  }
}

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.