Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Organization Account on Deletion #23930

Closed
danquack opened this issue Mar 29, 2022 · 5 comments · Fixed by #23931
Closed

Close Organization Account on Deletion #23930

danquack opened this issue Mar 29, 2022 · 5 comments · Fixed by #23931
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service.
Milestone

Comments

@danquack
Copy link
Contributor

danquack commented Mar 29, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Accounts can now be deleted as a matter of closing accounts. aws/aws-sdk-go#4338

Currently accounts are just removed from the org. With the new API they can be deleted.

New or Affected Resource(s)

  • aws_organizations_account

Potential Terraform Configuration

References

Announcement.
Blog post.

@danquack danquack added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 29, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/organizations Issues and PRs that pertain to the organizations service. labels Mar 29, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 29, 2022
@0x91
Copy link
Contributor

0x91 commented Mar 30, 2022

please for the love of god. i've waited years for this

@github-actions github-actions bot added this to the v4.9.0 milestone Apr 5, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@uday-projectn
Copy link

it seems updating terraform aws provider to 4.9.0 is deleting the account from terraform itself. But, when I check in aws console, it is showing as suspended, not as deleted. When I click on remove, it is showing the same error again.


ConstraintViolationException
The member account must be configured with a valid payment method, such as a credit card.

@mettke
Copy link

mettke commented May 3, 2022

@uday-projectn
There is no delete account in aws. Accounts are always suspended first for 90 days and then they are deleted. That way its possible for AWS to restore an account for that given time.

The remove button you mentioned does not delete the account but it removes it from the organization. And that's of course only possible when the account has a payment method.

In other words, if the account is marked as suspended after you ran terraform destroy with close_on_deletion: true then everything worked as its supposed to. Wait 90 days and it will be gone (give or take)

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants