Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/appstream_user_stack_association: prevent panic during resource read #24303

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22468

Output from acceptance testing:

--- PASS: TestAccAppStreamUserStackAssociation_disappears (24.42s)
--- PASS: TestAccAppStreamUserStackAssociation_basic (28.31s)
--- PASS: TestAccAppStreamUserStackAssociation_complete (45.05s)

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/appstream Issues and PRs that pertain to the appstream service. labels Apr 18, 2022
@anGie44 anGie44 marked this pull request as ready for review April 18, 2022 21:42
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Apr 19, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAppStreamUserStackAssociation_ PKG=appstream ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 2 -run='TestAccAppStreamUserStackAssociation_'  -timeout 180m
=== RUN   TestAccAppStreamUserStackAssociation_basic
=== PAUSE TestAccAppStreamUserStackAssociation_basic
=== RUN   TestAccAppStreamUserStackAssociation_disappears
=== PAUSE TestAccAppStreamUserStackAssociation_disappears
=== RUN   TestAccAppStreamUserStackAssociation_complete
=== PAUSE TestAccAppStreamUserStackAssociation_complete
=== CONT  TestAccAppStreamUserStackAssociation_basic
=== CONT  TestAccAppStreamUserStackAssociation_complete
--- PASS: TestAccAppStreamUserStackAssociation_basic (21.84s)
=== CONT  TestAccAppStreamUserStackAssociation_disappears
--- PASS: TestAccAppStreamUserStackAssociation_complete (39.81s)
--- PASS: TestAccAppStreamUserStackAssociation_disappears (18.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	44.468s

@anGie44 anGie44 added this to the v4.11.0 milestone Apr 19, 2022
@anGie44 anGie44 merged commit e43bce5 into main Apr 19, 2022
@anGie44 anGie44 deleted the b-appstream-user-stack-association-panic branch April 19, 2022 13:20
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/appstream Issues and PRs that pertain to the appstream service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing when we try to use the aws_appstream_user_stack_association resource
2 participants