Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include AttachmentsSources when updating SSM documents #24530

Merged
merged 3 commits into from
May 5, 2022

Conversation

pbuchner
Copy link
Contributor

@pbuchner pbuchner commented May 4, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21725

Output from acceptance testing:

make testacc TESTS=TestAccSSMDocument_package PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMDocument_package'  -timeout 180m
=== RUN   TestAccSSMDocument_package
=== PAUSE TestAccSSMDocument_package
=== CONT  TestAccSSMDocument_package
--- PASS: TestAccSSMDocument_package (48.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	59.888s
make testacc TESTS=TestAccSSMDocument_update PKG=ssm                                                                                                                                                              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMDocument_update'  -timeout 180m
=== RUN   TestAccSSMDocument_update
=== PAUSE TestAccSSMDocument_update
=== CONT  TestAccSSMDocument_update
--- PASS: TestAccSSMDocument_update (24.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	33.752s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. labels May 4, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @pbuchner 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label May 5, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 5, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSMDocument_package\|TestAccSSMDocument_update' PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSMDocument_package\|TestAccSSMDocument_update -timeout 180m
=== RUN   TestAccSSMDocument_update
=== PAUSE TestAccSSMDocument_update
=== RUN   TestAccSSMDocument_package
=== PAUSE TestAccSSMDocument_package
=== CONT  TestAccSSMDocument_update
=== CONT  TestAccSSMDocument_package
--- PASS: TestAccSSMDocument_update (50.70s)
--- PASS: TestAccSSMDocument_package (78.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	87.200s

@ewbankkit
Copy link
Contributor

@pbuchner Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a0d6930 into hashicorp:main May 5, 2022
@github-actions github-actions bot added this to the v4.13.0 milestone May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants