Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_connect_vocabulary #24849

Merged
merged 21 commits into from
Jul 21, 2022
Merged

r/aws_connect_vocabulary #24849

merged 21 commits into from
Jul 21, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented May 18, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24848

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnectVocabulary_serial' PKG=connect ACCTEST_TIMEOUT=500m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnectVocabulary_serial -timeout 500m
=== RUN   TestAccConnectVocabulary_serial
=== RUN   TestAccConnectVocabulary_serial/basic
=== RUN   TestAccConnectVocabulary_serial/disappears
=== RUN   TestAccConnectVocabulary_serial/update_tags
--- PASS: TestAccConnectVocabulary_serial (16830.09s)
    --- PASS: TestAccConnectVocabulary_serial/basic (5578.89s)
    --- PASS: TestAccConnectVocabulary_serial/disappears (5572.65s)
    --- PASS: TestAccConnectVocabulary_serial/update_tags (5678.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    16830.146s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. labels May 18, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 18, 2022
AdamTylerLynch
AdamTylerLynch approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit self-assigned this Jul 20, 2022
ewbankkit
ewbankkit approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=500m make testacc TESTARGS='-run=TestAccConnectVocabulary_serial' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnectVocabulary_serial -timeout 500m
=== RUN   TestAccConnectVocabulary_serial
=== RUN   TestAccConnectVocabulary_serial/disappears
=== RUN   TestAccConnectVocabulary_serial/update_tags
=== RUN   TestAccConnectVocabulary_serial/basic
--- PASS: TestAccConnectVocabulary_serial (16887.15s)
    --- PASS: TestAccConnectVocabulary_serial/disappears (5577.47s)
    --- PASS: TestAccConnectVocabulary_serial/update_tags (5621.21s)
    --- PASS: TestAccConnectVocabulary_serial/basic (5688.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	16901.208s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit removed their assignment Jul 21, 2022
@ewbankkit ewbankkit merged commit a6c5083 into hashicorp:main Jul 21, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 21, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@GlennChia GlennChia deleted the f-aws_connect_vocabulary branch August 6, 2022 02:56
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.

Add new resource for aws_connect_vocabulary
4 participants
@GlennChia @ewbankkit @AdamTylerLynch @justinretzolk