Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_transfer_server: Add support for TransferSecurityPolicy-2022-03 #25060

Merged
merged 6 commits into from
May 27, 2022

Conversation

meetreks
Copy link
Contributor

@meetreks meetreks commented May 26, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24967.

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added service/transfer Issues and PRs that pertain to the transfer service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 26, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 27, 2022
@ewbankkit ewbankkit self-assigned this May 27, 2022
@ewbankkit ewbankkit changed the title intial commit for review r/aws_transfer_server: Add support for TransferSecurityPolicy-2022-03 May 27, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label May 27, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/SecurityPolicy' PKG=transfer ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 2  -run=TestAccTransfer_serial/Server/SecurityPolicy -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
--- PASS: TestAccTransfer_serial (215.55s)
    --- PASS: TestAccTransfer_serial/Server (215.55s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (215.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	219.431s

@ewbankkit ewbankkit removed their assignment May 27, 2022
@ewbankkit
Copy link
Contributor

@meetreks Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 88212bd into hashicorp:main May 27, 2022
@github-actions github-actions bot added this to the v4.16.0 milestone May 27, 2022
@meetreks meetreks deleted the f-aws_transfer_server branch May 27, 2022 14:56
@github-actions
Copy link

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/transfer Issues and PRs that pertain to the transfer service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants