Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Data Source Provider for the "Service Discovery" Instances Resource #25823

Closed
matt-land opened this issue Jul 14, 2022 · 2 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@matt-land
Copy link

matt-land commented Jul 14, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Create a Data Source Provider for the Service Discovery Resources:

aws_service_discovery_instance

New or Affected Resource(s)

The following Data Sources would be new. (The resources already exist)

aws_service_discovery_instance

Potential Terraform Configuration

Below is a potential use case for how the data sources could be used in a Terraform Configuration

data "aws_service_discovery_dns_namespace" "foo" {
  count = length(var.control_plane_groups) > 0 ? 1 : 0
  type = "DNS_PRIVATE"
  name = "foo.io"
}

data "aws_service_discovery_service" "service_one" {
  count = length(var.control_plane_groups) > 0 ? 1 : 0
  name         = var.control_plane_groups[count.index]
  namespace_id = data.aws_service_discovery_dns_namespace.foo.id
}

data "aws_service_discovery_instances" "instances" {  # returns a list of matching instances
  service_id = data.aws_service_discovery_service.service_one.id  #required
  filter = [ # optional
    {name: "id", value: "blue*"},  # filter by InstanceId or prefix
    {name: "creator_request_id", value: ""}, # filter by CreatorRequestId or prefix
    {name: "health_status", value: "Healthy"}, # filter by health, accepts Healthy , Unhealthy , or Unknown
    {name: "attribute:AWS_INSTANCE_PORT", value: "8080"}, # filter by attribute AWS_INSTANCE_IPV4, AWS_INSTANCE_PORT, and custom attributes]
  ]
}


output "instances" {
  value = data.aws_service_discovery_instances.instances.*
}
# example response
[{
  id: "blue-one",
  creator_request_id: "",
  service_id: <service_id>,
  attributes: <attributes map of [AWS_INSTANCE_IPV4, AWS_INSTANCE_PORT, and custom attributes]>
  health_status: "Healthy"
}]

References

@matt-land matt-land added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 14, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. labels Jul 14, 2022
@matt-land matt-land changed the title Create a Data Source Provider for the "Service Discovery" Resources Create a Data Source Provider for the "Service Discovery" Instances Resource Jul 14, 2022
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 15, 2022
Copy link

github-actions bot commented Jul 4, 2024

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jul 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

2 participants