-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_cognito_identity_pool_provider_principal_tag 🐛 fix read operation when using oidc provider #25964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCognitoIdentityPoolProviderPrincipalTags_' PKG=cognitoidentity ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 2 -run=TestAccCognitoIdentityPoolProviderPrincipalTags_ -timeout 180m
=== RUN TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== RUN TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== RUN TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== RUN TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
=== CONT TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== CONT TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_basic (23.09s)
=== CONT TestAccCognitoIdentityPoolProviderPrincipalTags_updated
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_disappears (23.25s)
=== CONT TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_oidc (20.12s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_updated (39.92s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity 69.448s
@danquack Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24834
Output from acceptance testing: