Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cognito_identity_pool_provider_principal_tag 🐛 fix read operation when using oidc provider #25964

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Jul 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24834

Output from acceptance testing:

$ make testacc TESTS=TestAccCognitoIdentityPoolProviderPrincipalTags_ PKG=cognitoidentity                                                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 20 -run='TestAccCognitoIdentityPoolProviderPrincipalTags_'  -timeout 180m
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_oidc (27.04s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_basic (30.29s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_disappears (30.63s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_updated (74.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	75.951s
...

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 23, 2022
@danquack danquack changed the title 🐛 Fix read operation when using oidc provider 🐛 r/aws_cognito_identity_pool_provider_principal_tag Fix read operation when using oidc provider Jul 23, 2022
@danquack danquack changed the title 🐛 r/aws_cognito_identity_pool_provider_principal_tag Fix read operation when using oidc provider r/aws_cognito_identity_pool_provider_principal_tag 🐛 fix read operation when using oidc provider Jul 23, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 25, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIdentityPoolProviderPrincipalTags_' PKG=cognitoidentity ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 2  -run=TestAccCognitoIdentityPoolProviderPrincipalTags_ -timeout 180m
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_basic (23.09s)
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_updated
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_disappears (23.25s)
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_oidc
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_oidc (20.12s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_updated (39.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	69.448s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 89f9b72 into hashicorp:main Jul 26, 2022
@github-actions github-actions bot added this to the v4.24.0 milestone Jul 26, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants