Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sms_configuration attribute "sns_region" in the cognito_user_pool resource #26144

Closed
raphdg opened this issue Aug 5, 2022 · 2 comments · Fixed by #26684
Closed

Missing sms_configuration attribute "sns_region" in the cognito_user_pool resource #26144

raphdg opened this issue Aug 5, 2022 · 2 comments · Fixed by #26684
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Milestone

Comments

@raphdg
Copy link

raphdg commented Aug 5, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

According to the create user pool API documentation, we should be able to configure the SNS region in the SMS configuration.

   "SmsConfiguration": { 
      "ExternalId": "string",
      "SnsCallerArn": "string",
      "SnsRegion": "string"
   }

The attribute sns_region is not available in the sms_configuration of the aws_cognito_user_pool resource.

New or Affected Resource(s)

  • aws_cognito_user_pool

Potential Terraform Configuration

resource "aws_cognito_user_pool" "example" {
  # ... other configuration ...

  mfa_configuration          = "ON"
  sms_authentication_message = "Your code is {####}"

  sms_configuration {
    external_id    = "example"
    sns_caller_arn = aws_iam_role.example.arn
  }

  software_token_mfa_configuration {
    enabled = true
  }
}

should become something like:

resource "aws_cognito_user_pool" "example" {
  # ... other configuration ...

  mfa_configuration          = "ON"
  sms_authentication_message = "Your code is {####}"

  sms_configuration {
    external_id    = "example"
    sns_caller_arn = aws_iam_role.example.arn
    sns_region = "aws_region"
  }

  software_token_mfa_configuration {
    enabled = true
  }
}

References

@raphdg raphdg added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 5, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Aug 5, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 18, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 15, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Projects
None yet
2 participants