Fix expired statements during redshift-data state update

[rockpunk]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25882

After a redshift data statement is created, aws redshift-data describe-statement will only return a result for a short period of time when refreshing terraform state. After a while, it doesn't actually find the old statement, so terraform plan will fail trying to refresh the state:

❯ aws redshift-data describe-statement --id 346a11c9-9e89-476b-a68a-995a1d3f3a39

An error occurred (ValidationException) when calling the DescribeStatement operation: Could not retrieve the query result as it has expired after 1660423725.

This PR attempts to fix the issue by catching ValidationExceptions related to expired statements, and returning a dummy response that allows terraform state refresh to continue.

One impact of this change is that all expired statements will NOW BE REPLACED (the statements will be re-run) on next plan application.

If you don't want the statements to be re-run, use the ignore_changes lifecycle:

locals { 
  schemas = [ "schema1", "schema2", "schema3" ]
}

resource "aws_redshiftdata_statement" "create_schema" {
  for_each           = local.schemas
  cluster_identifier = "your-instance"
  database           = "yourdb"
  db_user            = "you"
  sql                = "create schema ${each.key}"

  lifecycle {
    ignore_changes = all
  }
}

Output from acceptance testing:

❯ make testacc TESTS=TestAccRedshiftDataStatement_basic PKG=redshiftdata
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftdata/... -v -count 1 -parallel 20 -run='TestAccRedshiftDataStatement_basic'  -timeout 180m
=== RUN   TestAccRedshiftDataStatement_basic
=== PAUSE TestAccRedshiftDataStatement_basic
=== CONT  TestAccRedshiftDataStatement_basic

--- PASS: TestAccRedshiftDataStatement_basic (332.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftdata	335.469s

[github-actions]

Welcome @rockpunk 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[wolfm89]

Is there a reason why this doesn't get merged?

[rockpunk]

Is there a reason why this doesn't get merged?

Probably a lack of community votes. I have raised this to our internal aws reps and will ping them again about it. In the meantime, future readers should continue to add a 👍 to the pr description above if they want this merged.

[wolfm89]

Any updates so far? The aws_redshiftdata_statement resource is not usable at all in the current state.

[ZMarouani]

please merge this , the aws_redshiftdata_statement resource is literally unusable !! or at least mention this in terraform documentation

update : As a workaround , you can use terraform rm 'redshiftdata_statement resource' to remove all instances of the expired resource from your terraform state file , then you can run terraform plan apply again without errors ( and add lifecycle to your redshiftdata resource to avoid having the error again )

[Lincon-Freitas]

Any news on this? It is a big issue!

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftDataStatement_' PKG=redshiftdata ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftdata/... -v -count 1 -parallel 2  -run=TestAccRedshiftDataStatement_ -timeout 180m
=== RUN   TestAccRedshiftDataStatement_basic
=== PAUSE TestAccRedshiftDataStatement_basic
=== RUN   TestAccRedshiftDataStatement_workgroup
=== PAUSE TestAccRedshiftDataStatement_workgroup
=== CONT  TestAccRedshiftDataStatement_basic
=== CONT  TestAccRedshiftDataStatement_workgroup
--- PASS: TestAccRedshiftDataStatement_basic (505.04s)
--- PASS: TestAccRedshiftDataStatement_workgroup (621.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftdata	626.763s

[ewbankkit]

@rockpunk Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.