aws_lambda_event_source_mapping: Add Kafka config blocks + consumer_group_id #26560

A122943 · 2022-08-31T05:35:05Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc PKG=lambda TESTS=TestAccLambdaEventSourceMapping_selfManagedKafka
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaEventSourceMapping_selfManagedKafka'  -timeout 180m
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafka
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafka
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafka
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafka (49.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	53.075s

$ make testacc PKG=lambda TESTS=TestAccLambdaEventSourceMapping_msk
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaEventSourceMapping_msk'  -timeout 180m
=== RUN   TestAccLambdaEventSourceMapping_msk
=== PAUSE TestAccLambdaEventSourceMapping_msk
=== CONT  TestAccLambdaEventSourceMapping_msk
--- PASS: TestAccLambdaEventSourceMapping_msk (3214.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	3217.450s

github-actions

Welcome @A122943 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

A122943 · 2022-08-31T15:20:53Z

Does anyone know why dependency checks / go mod is failing? I haven't altered any dependencies, and that check wasn't failing last night before I added documentation and a changelog entry today.

justinretzolk · 2022-08-31T17:06:58Z

Hey @A122943 👋 Thank you for your contribution! I believe that the failing check was something on our end. If you rebase, it should clear up the failing check.

A122943 · 2022-08-31T17:23:58Z

Hi @justinretzolk! That worked, thank you 😃 I'm happy to answer any questions you or another maintainer might have about these changes.

…g' to 'amazon_managed_kafka_event_source_config'.

… to 'self_managed_kafka_event_source_config'.

…fka_event_source_config' and 'self_managed_kafka_event_source_config'.

…ged_kafka_event_source_config' and 'self_managed_kafka_event_source_config'.

…rce_config' Computed. Acceptance test output: % make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_selfManagedKafka' PKG=lambda ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaEventSourceMapping_selfManagedKafka -timeout 180m === RUN TestAccLambdaEventSourceMapping_selfManagedKafka === PAUSE TestAccLambdaEventSourceMapping_selfManagedKafka === RUN TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig === PAUSE TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig === CONT TestAccLambdaEventSourceMapping_selfManagedKafka === CONT TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig --- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig (53.85s) --- PASS: TestAccLambdaEventSourceMapping_selfManagedKafka (59.01s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 62.775s

…ource_config' Computed. Acceptance test output: % make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_msk' PKG=lambda ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaEventSourceMapping_msk -timeout 180m === RUN TestAccLambdaEventSourceMapping_msk === PAUSE TestAccLambdaEventSourceMapping_msk === RUN TestAccLambdaEventSourceMapping_mskWithEventSourceConfig === PAUSE TestAccLambdaEventSourceMapping_mskWithEventSourceConfig === CONT TestAccLambdaEventSourceMapping_msk === CONT TestAccLambdaEventSourceMapping_mskWithEventSourceConfig --- PASS: TestAccLambdaEventSourceMapping_mskWithEventSourceConfig (3481.30s) --- PASS: TestAccLambdaEventSourceMapping_msk (3638.39s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 3642.258s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_msk' PKG=lambda      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaEventSourceMapping_msk -timeout 180m
=== RUN   TestAccLambdaEventSourceMapping_msk
=== PAUSE TestAccLambdaEventSourceMapping_msk
=== RUN   TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
=== PAUSE TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
=== CONT  TestAccLambdaEventSourceMapping_msk
=== CONT  TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
--- PASS: TestAccLambdaEventSourceMapping_mskWithEventSourceConfig (3481.30s)
--- PASS: TestAccLambdaEventSourceMapping_msk (3638.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	3642.258s
% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_selfManagedKafka' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaEventSourceMapping_selfManagedKafka -timeout 180m
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafka
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafka
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafka
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig (53.85s)
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafka (59.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	62.775s
% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_SQS_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaEventSourceMapping_SQS_ -timeout 180m
=== RUN   TestAccLambdaEventSourceMapping_SQS_basic
=== PAUSE TestAccLambdaEventSourceMapping_SQS_basic
=== RUN   TestAccLambdaEventSourceMapping_SQS_batchWindow
=== PAUSE TestAccLambdaEventSourceMapping_SQS_batchWindow
=== RUN   TestAccLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== PAUSE TestAccLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== RUN   TestAccLambdaEventSourceMapping_SQS_filterCriteria
=== PAUSE TestAccLambdaEventSourceMapping_SQS_filterCriteria
=== CONT  TestAccLambdaEventSourceMapping_SQS_basic
=== CONT  TestAccLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT  TestAccLambdaEventSourceMapping_SQS_filterCriteria
--- PASS: TestAccLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (93.91s)
=== CONT  TestAccLambdaEventSourceMapping_SQS_batchWindow
--- PASS: TestAccLambdaEventSourceMapping_SQS_basic (114.10s)
--- PASS: TestAccLambdaEventSourceMapping_SQS_batchWindow (66.82s)
--- PASS: TestAccLambdaEventSourceMapping_SQS_filterCriteria (188.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	192.527s

ewbankkit · 2022-09-01T20:08:35Z

@A122943 Thanks for the contribution 🎉 👏.
Overall everything was great. I tweaked the new attribute names to match the underling AWS API structure names and made them ForceNew and Computed as they cannot be updated after creation and as you mention in the documentation, if not specified, generated values are returned.

A122943 · 2022-09-01T21:19:28Z

@A122943 Thanks for the contribution 🎉 👏. Overall everything was great. I tweaked the new attribute names to match the underling AWS API structure names and made them ForceNew and Computed as they cannot be updated after creation and as you mention in the documentation, if not specified, generated values are returned.

@ewbankkit A huge thanks for polishing and merging this PR :-)

I have one question:

Does the presence of ForceNew alongside Computed allow users to specify a value for consumer_group_id upon resource creation?

Consumer_group_id should be specifiable upon creation of the resource. But in the docs, I read that

Computed is often used to represent values that are not user configurable [...] Computed can be combined with other attributes to achieve specific behaviors [...]

Thank you -- just double checking 🦅

ewbankkit · 2022-09-01T21:32:41Z

@A122943 You are correct that an attribute marked with just Computed cannot be specified by the user, but with an additional Optional (which these new attributes do have) they can be configured.

github-actions · 2022-09-02T13:18:54Z

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-10-04T02:40:31Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

A122943 added 5 commits August 29, 2022 12:15

SelfManagedKafkaConfiguration

3236261

Update event_source_mapping.go

55d19f4

rename self_managed_kafka_config

e24b9ac

update test

783b9f5

correct consumer_group_id schema

f4e99b5

github-actions bot reviewed Aug 31, 2022

View reviewed changes

A122943 added 2 commits August 30, 2022 23:48

add amazon_managed_kafka_config

45ad907

add amazon_managed_kafka_config tests

22374c7

A122943 marked this pull request as ready for review August 31, 2022 13:47

A122943 added 2 commits August 31, 2022 08:03

Create 26560.txt

841f3f6

update website/docs

2989eff

github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 31, 2022

Merge branch 'main' into patch-1

616451c

A122943 changed the title ~~aws_lambda_event_source_mapping: Add self_managed_kafka_config block and consumer_group_id~~ aws_lambda_event_source_mapping: Add kafka config blocks & consumer_group_id Aug 31, 2022

A122943 changed the title ~~aws_lambda_event_source_mapping: Add kafka config blocks & consumer_group_id~~ aws_lambda_event_source_mapping: Add kafka config blocks + consumer_group_id Aug 31, 2022

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 31, 2022

Merge branch 'hashicorp:main' into patch-1

953a829

A122943 changed the title ~~aws_lambda_event_source_mapping: Add kafka config blocks + consumer_group_id~~ aws_lambda_event_source_mapping: Add Kafka config blocks + consumer_group_id Aug 31, 2022

ewbankkit added 4 commits September 1, 2022 14:25

Tweak CHANGELOG entry.

018e799

Fix terrafmt errors.

6c79e1b

r/aws_lambda_event_source_mapping: Rename 'amazon_managed_kafka_confi…

9116af4

…g' to 'amazon_managed_kafka_event_source_config'.

r/aws_lambda_event_source_mapping: Rename 'self_managed_kafka_config'…

9f79636

… to 'self_managed_kafka_event_source_config'.

ewbankkit and others added 7 commits September 1, 2022 14:39

Remove whitespace.

747c090

r/aws_lambda_event_source_mapping: Add ForceNew to 'amazon_managed_ka…

3bb0b1f

…fka_event_source_config' and 'self_managed_kafka_event_source_config'.

r/aws_lambda_event_source_mapping: Test with and without 'amazon_mana…

b8c3543

…ged_kafka_event_source_config' and 'self_managed_kafka_event_source_config'.

Merge branch 'hashicorp:main' into patch-1

bda0e3d

Merge commit 'a8d6b461c84e743d8c2a463b32fc49cce145408c' into HEAD

55837a4

github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 1, 2022

ewbankkit approved these changes Sep 1, 2022

View reviewed changes

ewbankkit merged commit 60ec508 into hashicorp:main Sep 1, 2022

github-actions bot added this to the v4.29.0 milestone Sep 1, 2022

github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

aws_lambda_event_source_mapping: Add Kafka config blocks + consumer_group_id #26560

aws_lambda_event_source_mapping: Add Kafka config blocks + consumer_group_id #26560

A122943 commented Aug 31, 2022 •

edited

Loading

github-actions bot left a comment

A122943 commented Aug 31, 2022 •

edited

Loading

justinretzolk commented Aug 31, 2022

A122943 commented Aug 31, 2022

ewbankkit left a comment •

edited

Loading

ewbankkit commented Sep 1, 2022 •

edited

Loading

A122943 commented Sep 1, 2022 •

edited

Loading

ewbankkit commented Sep 1, 2022 •

edited

Loading

github-actions bot commented Sep 2, 2022

github-actions bot commented Oct 4, 2022

aws_lambda_event_source_mapping: Add Kafka config blocks + consumer_group_id #26560

aws_lambda_event_source_mapping: Add Kafka config blocks + consumer_group_id #26560

Conversation

A122943 commented Aug 31, 2022 • edited Loading

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

A122943 commented Aug 31, 2022 • edited Loading

justinretzolk commented Aug 31, 2022

A122943 commented Aug 31, 2022

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

ewbankkit commented Sep 1, 2022 • edited Loading

A122943 commented Sep 1, 2022 • edited Loading

ewbankkit commented Sep 1, 2022 • edited Loading

github-actions bot commented Sep 2, 2022

github-actions bot commented Oct 4, 2022

A122943 commented Aug 31, 2022 •

edited

Loading

A122943 commented Aug 31, 2022 •

edited

Loading

ewbankkit left a comment •

edited

Loading

ewbankkit commented Sep 1, 2022 •

edited

Loading

A122943 commented Sep 1, 2022 •

edited

Loading

ewbankkit commented Sep 1, 2022 •

edited

Loading