Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adding 'upgrade' cloudwatch log export type for AWS RDS Cluster #26792

Conversation

matharoo
Copy link
Contributor

@matharoo matharoo commented Sep 13, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR adds the upgrade cloudwatch log export type which is supported by AWS for RDS clusters with Postgres engine.

Affected resource: aws_rds_cluster

Closes #26791

Output from acceptance testing:

[ Need help with running test make testacc TESTS=TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql PKG=rds ]:

$ make testacc TESTS=TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql PKG=rds

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. labels Sep 13, 2022
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Sep 13, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Sep 13, 2022
@matharoo matharoo changed the title Adding 'upgrade' cloudwatch log export type for AWS RDS Cluster Fix: Adding 'upgrade' cloudwatch log export type for AWS RDS Cluster Sep 16, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 28, 2022
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Sep 28, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Sep 28, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql' PKG=rds ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 1  -run=TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql -timeout 360m
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (1739.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1743.501s

@ewbankkit
Copy link
Contributor

@matharoo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 74ee3ac into hashicorp:main Sep 28, 2022
@github-actions github-actions bot added this to the v4.33.0 milestone Sep 28, 2022
@github-actions
Copy link

This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when setting 'upgrade' cloudwatch export log type for AWS RDS Cluster with postgres engine.
2 participants