Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_s3control_storage_lens_configuration #27097

Merged
merged 31 commits into from
Oct 7, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 4, 2022

Description

Adds the aws_s3control_storage_lens_configuration resource.

Relations

Closes #16310.

Acceptance Test Output

%  make testacc TESTARGS='-run=TestAccS3ControlStorageLensConfiguration_' PKG=s3control ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 2  -run=TestAccS3ControlStorageLensConfiguration_ -timeout 180m
=== RUN   TestAccS3ControlStorageLensConfiguration_basic
=== PAUSE TestAccS3ControlStorageLensConfiguration_basic
=== RUN   TestAccS3ControlStorageLensConfiguration_disappears
=== PAUSE TestAccS3ControlStorageLensConfiguration_disappears
=== RUN   TestAccS3ControlStorageLensConfiguration_tags
=== PAUSE TestAccS3ControlStorageLensConfiguration_tags
=== RUN   TestAccS3ControlStorageLensConfiguration_update
=== PAUSE TestAccS3ControlStorageLensConfiguration_update
=== CONT  TestAccS3ControlStorageLensConfiguration_basic
=== CONT  TestAccS3ControlStorageLensConfiguration_tags
--- PASS: TestAccS3ControlStorageLensConfiguration_basic (20.67s)
=== CONT  TestAccS3ControlStorageLensConfiguration_update
--- PASS: TestAccS3ControlStorageLensConfiguration_tags (47.39s)
=== CONT  TestAccS3ControlStorageLensConfiguration_disappears
--- PASS: TestAccS3ControlStorageLensConfiguration_disappears (13.14s)
--- PASS: TestAccS3ControlStorageLensConfiguration_update (42.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	67.015s

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 4, 2022
@ewbankkit
Copy link
Contributor Author

TestAccS3ControlStorageLensConfiguration_disappears is hitting this bug: aws/aws-sdk-go#4577.

@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Oct 5, 2022
@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Oct 6, 2022
@ewbankkit ewbankkit marked this pull request as ready for review October 6, 2022 19:10
@gdavison gdavison self-assigned this Oct 6, 2022
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments, otherwise looks good

internal/service/s3control/storage_lens_configuration.go Outdated Show resolved Hide resolved
internal/service/s3control/storage_lens_configuration.go Outdated Show resolved Hide resolved
internal/service/s3control/sweep.go Outdated Show resolved Hide resolved
@ewbankkit ewbankkit merged commit 86625ca into main Oct 7, 2022
@ewbankkit ewbankkit deleted the f-aws_s3control_storage_lens branch October 7, 2022 13:41
@github-actions github-actions bot added this to the v4.35.0 milestone Oct 7, 2022
github-actions bot pushed a commit that referenced this pull request Oct 7, 2022
@github-actions
Copy link

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon S3 Storage Lens configuration
2 participants