Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Attribute arn_without_revision on aws_ecs_task_definition #27119

Closed
DBX12 opened this issue Oct 6, 2022 · 3 comments · Fixed by #27351
Closed

[Enhancement]: Attribute arn_without_revision on aws_ecs_task_definition #27119

DBX12 opened this issue Oct 6, 2022 · 3 comments · Fixed by #27351
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@DBX12
Copy link
Contributor

DBX12 commented Oct 6, 2022

Description

I think this is highly useful if you are in an environment where you always want to use the latest active revision of a task definition. Per documentation, removing the revision number from the ARN of a task definition makes AWS use the latest, active revision of that task definition.
Assume you have a aws_task_definition.this defined somewhere else with full ARN arn:aws:ecs:eu-central-1:000000000000:task-definition/my-task-def:42. To make AWS use the latest active revision, one has to do that in terraform:

resource "aws_ecs_service" "this" {
  task_definition = replace(aws_ecs_task_definition.this.arn, "/:\\d+$/", "")
}

With my proposed change, one could do it like this:

resource "aws_ecs_service" "this" {
  task_definition = aws_ecs_task_definition.this.arn_without_revision
  # aws_ecs_task_definition.this.arn_without_revision would output
  # arn:aws:ecs:eu-central-1:000000000000:task-definition/my-task-def
}

Affected Resource(s) and/or Data Source(s)

  • aws_ecs_task_definition

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

Yes

@DBX12 DBX12 added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/ecs Issues and PRs that pertain to the ecs service. label Oct 6, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 31, 2022
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 11, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants