-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FIS support for EKS Cluster #27337
Added FIS support for EKS Cluster #27337
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @akshaychopra5207 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Any update on when this can be picked up ? @ewbankkit |
Hi @ewbankkit, can you please revise this open PR? This bug still occurs on the latest version. Can you tell me what has to be done? First, of course rebasing 😂 |
if necesssary, I would take it and do the rest of the work |
any news on this one? |
# Conflicts: # internal/service/fis/experiment_template.go # internal/service/fis/experiment_template_test.go # website/docs/r/fis_experiment_template.html.markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccFISExperimentTemplate_' PKG=fis ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 2 -run=TestAccFISExperimentTemplate_ -timeout 180m
=== RUN TestAccFISExperimentTemplate_basic
=== PAUSE TestAccFISExperimentTemplate_basic
=== RUN TestAccFISExperimentTemplate_disappears
=== PAUSE TestAccFISExperimentTemplate_disappears
=== RUN TestAccFISExperimentTemplate_update
=== PAUSE TestAccFISExperimentTemplate_update
=== RUN TestAccFISExperimentTemplate_spot
=== PAUSE TestAccFISExperimentTemplate_spot
=== RUN TestAccFISExperimentTemplate_eks
=== PAUSE TestAccFISExperimentTemplate_eks
=== CONT TestAccFISExperimentTemplate_basic
=== CONT TestAccFISExperimentTemplate_spot
--- PASS: TestAccFISExperimentTemplate_spot (16.49s)
=== CONT TestAccFISExperimentTemplate_update
=== CONT TestAccFISExperimentTemplate_eks
--- PASS: TestAccFISExperimentTemplate_basic (19.41s)
--- PASS: TestAccFISExperimentTemplate_update (28.43s)
=== CONT TestAccFISExperimentTemplate_disappears
--- PASS: TestAccFISExperimentTemplate_disappears (14.02s)
--- PASS: TestAccFISExperimentTemplate_eks (752.67s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fis 777.643s
@akshaychopra5207 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This is to fix a validation failure for Cluster(EKS Cluster)
Relations
Closes #27314
References
Output from Acceptance Testing