Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FIS support for EKS Cluster #27337

Merged
merged 5 commits into from
Apr 27, 2023

Conversation

akshaychopra5207
Copy link
Contributor

Description

This is to fix a validation failure for Cluster(EKS Cluster)

Relations

Closes #27314

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccFISExperimentTemplate_eks  PKG=fis
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 20 -run='TestAccFISExperimentTemplate_eks'  -timeout 180m
=== RUN   TestAccFISExperimentTemplate_eks
=== PAUSE TestAccFISExperimentTemplate_eks
=== CONT  TestAccFISExperimentTemplate_eks
--- PASS: TestAccFISExperimentTemplate_eks (647.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fis        648.932s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/fis Issues and PRs that pertain to the fis service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Oct 19, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @akshaychopra5207 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2022
@akshaychopra5207
Copy link
Contributor Author

Any update on when this can be picked up ? @ewbankkit

@bcubk
Copy link

bcubk commented Nov 28, 2022

Hi @ewbankkit, can you please revise this open PR? This bug still occurs on the latest version. Can you tell me what has to be done? First, of course rebasing 😂

@bcubk
Copy link

bcubk commented Nov 28, 2022

if necesssary, I would take it and do the rest of the work

@akshaychopra5207
Copy link
Contributor Author

any news on this one?

# Conflicts:
#	internal/service/fis/experiment_template.go
#	internal/service/fis/experiment_template_test.go
#	website/docs/r/fis_experiment_template.html.markdown
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFISExperimentTemplate_' PKG=fis ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 2  -run=TestAccFISExperimentTemplate_ -timeout 180m
=== RUN   TestAccFISExperimentTemplate_basic
=== PAUSE TestAccFISExperimentTemplate_basic
=== RUN   TestAccFISExperimentTemplate_disappears
=== PAUSE TestAccFISExperimentTemplate_disappears
=== RUN   TestAccFISExperimentTemplate_update
=== PAUSE TestAccFISExperimentTemplate_update
=== RUN   TestAccFISExperimentTemplate_spot
=== PAUSE TestAccFISExperimentTemplate_spot
=== RUN   TestAccFISExperimentTemplate_eks
=== PAUSE TestAccFISExperimentTemplate_eks
=== CONT  TestAccFISExperimentTemplate_basic
=== CONT  TestAccFISExperimentTemplate_spot
--- PASS: TestAccFISExperimentTemplate_spot (16.49s)
=== CONT  TestAccFISExperimentTemplate_update
=== CONT  TestAccFISExperimentTemplate_eks
--- PASS: TestAccFISExperimentTemplate_basic (19.41s)
--- PASS: TestAccFISExperimentTemplate_update (28.43s)
=== CONT  TestAccFISExperimentTemplate_disappears
--- PASS: TestAccFISExperimentTemplate_disappears (14.02s)
--- PASS: TestAccFISExperimentTemplate_eks (752.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fis	777.643s

@ewbankkit
Copy link
Contributor

@akshaychopra5207 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 543f59f into hashicorp:main Apr 27, 2023
@github-actions github-actions bot added this to the v4.65.0 milestone Apr 27, 2023
@github-actions
Copy link

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fis Issues and PRs that pertain to the fis service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_fis_experiment_template should support resource of type EKS Cluster
3 participants