Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws_api_gateway_authorizer datasource #28148

Merged

Conversation

iwarapter
Copy link
Contributor

@iwarapter iwarapter commented Dec 2, 2022

Description

Implementing aws_api_gateway_authorizer data source

Relations

Closes #28145.
Closes #16410.

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccAPIGatewayAuthorizerDataSource PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayAuthorizerDataSource'  -timeout 180m
=== RUN   TestAccAPIGatewayAuthorizerDataSource
=== PAUSE TestAccAPIGatewayAuthorizerDataSource
=== CONT  TestAccAPIGatewayAuthorizerDataSource
--- PASS: TestAccAPIGatewayAuthorizerDataSource (45.67s)
PASS

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 2, 2022
@iwarapter iwarapter force-pushed the f-aws_api_gateway_authorizer_data_source branch from a3f3a07 to 58a1e77 Compare December 2, 2022 19:42
@DrFaust92 DrFaust92 added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 4, 2022
@iwarapter iwarapter force-pushed the f-aws_api_gateway_authorizer_data_source branch from 58a1e77 to d120103 Compare December 4, 2022 14:27
@iwarapter iwarapter force-pushed the f-aws_api_gateway_authorizer_data_source branch from d120103 to bf077bd Compare March 7, 2023 09:37
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 7, 2023
@iwarapter iwarapter force-pushed the f-aws_api_gateway_authorizer_data_source branch from bf077bd to 052335b Compare March 9, 2023 20:49
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwarapter
Copy link
Contributor Author

Hey @DrFaust92 any idea when this might be merged? Thanks for the approval 👍

@ewbankkit ewbankkit self-assigned this Apr 25, 2023
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAPIGatewayAuthorizersDataSource_' PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20  -run=TestAccAPIGatewayAuthorizersDataSource_ -timeout 180m
=== RUN   TestAccAPIGatewayAuthorizersDataSource_basic
=== PAUSE TestAccAPIGatewayAuthorizersDataSource_basic
=== CONT  TestAccAPIGatewayAuthorizersDataSource_basic
--- PASS: TestAccAPIGatewayAuthorizersDataSource_basic (30.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	35.545s
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAPIGatewayAuthorizerDataSource_' PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20  -run=TestAccAPIGatewayAuthorizerDataSource_ -timeout 180m
=== RUN   TestAccAPIGatewayAuthorizerDataSource_basic
=== PAUSE TestAccAPIGatewayAuthorizerDataSource_basic
=== CONT  TestAccAPIGatewayAuthorizerDataSource_basic
--- PASS: TestAccAPIGatewayAuthorizerDataSource_basic (30.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	36.487s
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 25, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAPIGatewayAuthorizerDataSource_' PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20  -run=TestAccAPIGatewayAuthorizerDataSource_ -timeout 180m
=== RUN   TestAccAPIGatewayAuthorizerDataSource_basic
=== PAUSE TestAccAPIGatewayAuthorizerDataSource_basic
=== CONT  TestAccAPIGatewayAuthorizerDataSource_basic
--- PASS: TestAccAPIGatewayAuthorizerDataSource_basic (30.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	36.487s
% make testacc TESTARGS='-run=TestAccAPIGatewayAuthorizersDataSource_' PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20  -run=TestAccAPIGatewayAuthorizersDataSource_ -timeout 180m
=== RUN   TestAccAPIGatewayAuthorizersDataSource_basic
=== PAUSE TestAccAPIGatewayAuthorizersDataSource_basic
=== CONT  TestAccAPIGatewayAuthorizersDataSource_basic
--- PASS: TestAccAPIGatewayAuthorizersDataSource_basic (30.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	35.545s

@ewbankkit
Copy link
Contributor

@iwarapter Thanks for the contribution 🎉 👏.
Following our guidelines I split this functionality into two data sources, aws_api_gateway_authorizers and aws_api_gateway_authorizer.

@ewbankkit ewbankkit merged commit 5fffb7b into hashicorp:main Apr 25, 2023
@github-actions github-actions bot added this to the v4.65.0 milestone Apr 25, 2023
@github-actions
Copy link

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@iwarapter iwarapter deleted the f-aws_api_gateway_authorizer_data_source branch April 28, 2023 11:42
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/apigateway Issues and PRs that pertain to the apigateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: aws_api_gateway_authorizer data source No data source for "aws_api_gateway_authorizer"
4 participants