Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Use Correct API's for CloudWatch Logs Tagging #28322

Closed
AMMullan opened this issue Dec 13, 2022 · 3 comments · Fixed by #28359
Closed

[Enhancement]: Use Correct API's for CloudWatch Logs Tagging #28322

AMMullan opened this issue Dec 13, 2022 · 3 comments · Fixed by #28359
Labels
service/logs Issues and PRs that pertain to the logs service. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@AMMullan
Copy link

Description

We got notified by AWS that we were using now out of development API's and found that it was Terraform that was making these calls.

This is the breakdown from AWS:

We identified that you are using tagging APIs and recommend use the following new APIs that have “Resource” as the suffix, instead of “LogGroup”.

logs:TagResource
logs:UntagResource
logs:ListTagsForResource

The CloudWatch Logs team will not remove previous tagging APIs but the following APIs will no longer be actively developed:
TagLogGroup
UntagLogGroup
ListTagsLogGroup

Presumably Terraform should be using the newer APIs so that it's following AWS best practices?

(NB: CloudFormation is also using these old APIs lol!)

Affected Resource(s) and/or Data Source(s)

aws_cloudwatch_log_group

Potential Terraform Configuration

No Change

References

No response

Would you like to implement a fix?

None

@AMMullan AMMullan added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 13, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. tags Pertains to resource tagging. service/logs Issues and PRs that pertain to the logs service. and removed needs-triage Waiting for first response or review from a maintainer. enhancement Requests to existing resources that expand the functionality or scope. labels Dec 13, 2022
@ewbankkit
Copy link
Contributor

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/logs Issues and PRs that pertain to the logs service. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants