-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_cloudwatch_log_group: Use log group-specific tagging functions #28492
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc TESTARGS='-run=TestAccLogsGroup' PKG=logs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 3 -run=TestAccLogsGroup -timeout 180m
=== RUN TestAccLogsGroupDataSource_basic
=== PAUSE TestAccLogsGroupDataSource_basic
=== RUN TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN TestAccLogsGroup_nameGenerate
=== PAUSE TestAccLogsGroup_nameGenerate
=== RUN TestAccLogsGroup_namePrefix
=== PAUSE TestAccLogsGroup_namePrefix
=== RUN TestAccLogsGroup_disappears
=== PAUSE TestAccLogsGroup_disappears
=== RUN TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== RUN TestAccLogsGroup_kmsKey
=== PAUSE TestAccLogsGroup_kmsKey
=== RUN TestAccLogsGroup_retentionPolicy
=== PAUSE TestAccLogsGroup_retentionPolicy
=== RUN TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== RUN TestAccLogsGroup_skipDestroy
=== PAUSE TestAccLogsGroup_skipDestroy
=== RUN TestAccLogsGroupsDataSource_basic
=== PAUSE TestAccLogsGroupsDataSource_basic
=== RUN TestAccLogsGroupsDataSource_noPrefix
=== PAUSE TestAccLogsGroupsDataSource_noPrefix
=== CONT TestAccLogsGroupDataSource_basic
=== CONT TestAccLogsGroupsDataSource_noPrefix
=== CONT TestAccLogsGroup_kmsKey
--- PASS: TestAccLogsGroupDataSource_basic (12.92s)
=== CONT TestAccLogsGroup_namePrefix
--- PASS: TestAccLogsGroupsDataSource_noPrefix (12.99s)
=== CONT TestAccLogsGroup_tags
--- PASS: TestAccLogsGroup_namePrefix (13.36s)
=== CONT TestAccLogsGroup_disappears
--- PASS: TestAccLogsGroup_disappears (9.03s)
=== CONT TestAccLogsGroup_skipDestroy
--- PASS: TestAccLogsGroup_kmsKey (38.74s)
=== CONT TestAccLogsGroupsDataSource_basic
--- PASS: TestAccLogsGroup_tags (30.42s)
=== CONT TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_skipDestroy (10.18s)
=== CONT TestAccLogsGroup_nameGenerate
--- PASS: TestAccLogsGroupsDataSource_basic (11.35s)
=== CONT TestAccLogsGroup_basic
--- PASS: TestAccLogsGroup_multiple (11.09s)
=== CONT TestAccLogsGroup_retentionPolicy
--- PASS: TestAccLogsGroup_nameGenerate (12.71s)
--- PASS: TestAccLogsGroup_basic (12.74s)
--- PASS: TestAccLogsGroup_retentionPolicy (22.25s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 79.786s
This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Restores use of the
ListTagsLogGroup
,TagLogGroup
andUntagLogGroup
APIs to avoid AWS-managed IAM policy errors.Relations
Closes #28422.
Closes #28491.
Relates #28359.
References
Output from Acceptance Testing