Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid direct calls to Resource.Delete in sweepers and acceptance tests #28556

Closed
ewbankkit opened this issue Dec 23, 2022 · 2 comments · Fixed by #29021
Closed

Avoid direct calls to Resource.Delete in sweepers and acceptance tests #28556

ewbankkit opened this issue Dec 23, 2022 · 2 comments · Fixed by #29021
Labels
sweeper Pertains to changes to or issues with the sweeper. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Dec 23, 2022 •
edited
Loading

With a future switch to WithoutTimeout CRUD handlers, avoid direct calls to Resource.Delete in sweepers and acceptance tests.

  • In acceptance tests use acctest.DeleteResource
  • In sweepers use the sweep.SweepOrchestrator facility
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Dec 23, 2022
@ewbankkit ewbankkit changed the title Avoid direct calls to Resource.Delete in sweepers and acceptance tests. Avoid direct calls to Resource.Delete in sweepers and acceptance tests Dec 23, 2022
@ewbankkit ewbankkit added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Dec 23, 2022
@ewbankkit ewbankkit mentioned this issue Dec 23, 2022
Merged
@ewbankkit ewbankkit mentioned this issue Jan 6, 2023
Merged
@ewbankkit ewbankkit mentioned this issue Jan 20, 2023
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
sweeper Pertains to changes to or issues with the sweeper. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes sweepers after Context migration hashicorp/terraform-provider-aws
1 participant
@ewbankkit