Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Lookup AMP Workspace by Alias #28568

Conversation

cbbond
Copy link

@cbbond cbbond commented Dec 23, 2022

Description

Adds the ability to lookup an AMP workspace by workspace alias. Previously the provider allowed lookups by workspace_id, this change requires that only one of workspace_id or alias is specified.

Relations

Closes #26400

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccAMPWorkspaceDataSource_' PKG=amp ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 1  -run=TestAccAMPWorkspaceDataSource_ -timeout 180m
=== RUN   TestAccAMPWorkspaceDataSource_workspace_id
--- PASS: TestAccAMPWorkspaceDataSource_workspace_id (18.06s)
=== RUN   TestAccAMPWorkspaceDataSource_alias
--- PASS: TestAccAMPWorkspaceDataSource_alias (16.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	37.454s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/amp Issues and PRs that pertain to the amp service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Dec 23, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @cbbond 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 23, 2022
@cbbond
Copy link
Author

cbbond commented Dec 23, 2022

Apologies, I just realized that workspace aliases do not need to be unique. I will close this and open another PR for a aws_prometheus_workspaces data source, similar to data.aws_iam.iam_roles.

@cbbond cbbond closed this Dec 23, 2022
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Dec 23, 2022
@cbbond cbbond deleted the f-lookup-aws_prometheus_workspace-data-source-by-alias branch December 25, 2022 21:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/amp Issues and PRs that pertain to the amp service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_amp_workspace query by alias instead of workspace_id
1 participant