-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: aws_ec2_placement_group spread level #28596
bugfix: aws_ec2_placement_group spread level #28596
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Is there a way to run/limit the linters locally to only files that have had changes? Something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2PlacementGroup_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2PlacementGroup_ -timeout 180m
=== RUN TestAccEC2PlacementGroup_basic
=== PAUSE TestAccEC2PlacementGroup_basic
=== RUN TestAccEC2PlacementGroup_disappears
=== PAUSE TestAccEC2PlacementGroup_disappears
=== RUN TestAccEC2PlacementGroup_tags
=== PAUSE TestAccEC2PlacementGroup_tags
=== RUN TestAccEC2PlacementGroup_partitionCount
=== PAUSE TestAccEC2PlacementGroup_partitionCount
=== RUN TestAccEC2PlacementGroup_defaultSpreadLevel
=== PAUSE TestAccEC2PlacementGroup_defaultSpreadLevel
=== RUN TestAccEC2PlacementGroup_spreadLevel
=== PAUSE TestAccEC2PlacementGroup_spreadLevel
=== CONT TestAccEC2PlacementGroup_basic
=== CONT TestAccEC2PlacementGroup_partitionCount
--- PASS: TestAccEC2PlacementGroup_basic (24.74s)
=== CONT TestAccEC2PlacementGroup_tags
--- PASS: TestAccEC2PlacementGroup_partitionCount (24.84s)
=== CONT TestAccEC2PlacementGroup_disappears
--- PASS: TestAccEC2PlacementGroup_disappears (17.06s)
=== CONT TestAccEC2PlacementGroup_spreadLevel
--- PASS: TestAccEC2PlacementGroup_spreadLevel (22.89s)
=== CONT TestAccEC2PlacementGroup_defaultSpreadLevel
--- PASS: TestAccEC2PlacementGroup_tags (53.49s)
--- PASS: TestAccEC2PlacementGroup_defaultSpreadLevel (22.92s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 97.809s
@bennylu2 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
As mentioned in the bug that was reported, the new
spread_level
argument forced replacements. This was because the API returnsrack
as a default value whenstrategy
is set tospread
.Relations
Closes #26958
Tests