Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: aws_ec2_placement_group spread level #28596

Merged

Conversation

bennylu2
Copy link
Contributor

@bennylu2 bennylu2 commented Dec 28, 2022

Description

As mentioned in the bug that was reported, the new spread_level argument forced replacements. This was because the API returns rack as a default value when strategy is set to spread.

  • Fixed up documentation
  • Removed double-quotes to standardize

Relations

Closes #26958

Tests

make testacc TESTS='TestAccEC2PlacementGroup_spreadLevel' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2PlacementGroup_spreadLevel'  -timeout 180m
=== RUN   TestAccEC2PlacementGroup_spreadLevel
=== PAUSE TestAccEC2PlacementGroup_spreadLevel
=== CONT  TestAccEC2PlacementGroup_spreadLevel
--- PASS: TestAccEC2PlacementGroup_spreadLevel (33.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        50.558s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Dec 28, 2022
@bennylu2 bennylu2 changed the title B aws ec2 placement group spread level b/aws_ec2_placement_group spread level Dec 28, 2022
@bennylu2 bennylu2 changed the title b/aws_ec2_placement_group spread level bugfix: aws_ec2_placement_group spread level Dec 28, 2022
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 29, 2022
@bennylu2
Copy link
Contributor Author

Is there a way to run/limit the linters locally to only files that have had changes? Something like pre-commit or being able to specify a path? I feel like I may be missing something unless everyone's supposed to lint the entire codebase each time

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2PlacementGroup_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2PlacementGroup_ -timeout 180m
=== RUN   TestAccEC2PlacementGroup_basic
=== PAUSE TestAccEC2PlacementGroup_basic
=== RUN   TestAccEC2PlacementGroup_disappears
=== PAUSE TestAccEC2PlacementGroup_disappears
=== RUN   TestAccEC2PlacementGroup_tags
=== PAUSE TestAccEC2PlacementGroup_tags
=== RUN   TestAccEC2PlacementGroup_partitionCount
=== PAUSE TestAccEC2PlacementGroup_partitionCount
=== RUN   TestAccEC2PlacementGroup_defaultSpreadLevel
=== PAUSE TestAccEC2PlacementGroup_defaultSpreadLevel
=== RUN   TestAccEC2PlacementGroup_spreadLevel
=== PAUSE TestAccEC2PlacementGroup_spreadLevel
=== CONT  TestAccEC2PlacementGroup_basic
=== CONT  TestAccEC2PlacementGroup_partitionCount
--- PASS: TestAccEC2PlacementGroup_basic (24.74s)
=== CONT  TestAccEC2PlacementGroup_tags
--- PASS: TestAccEC2PlacementGroup_partitionCount (24.84s)
=== CONT  TestAccEC2PlacementGroup_disappears
--- PASS: TestAccEC2PlacementGroup_disappears (17.06s)
=== CONT  TestAccEC2PlacementGroup_spreadLevel
--- PASS: TestAccEC2PlacementGroup_spreadLevel (22.89s)
=== CONT  TestAccEC2PlacementGroup_defaultSpreadLevel
--- PASS: TestAccEC2PlacementGroup_tags (53.49s)
--- PASS: TestAccEC2PlacementGroup_defaultSpreadLevel (22.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	97.809s

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 23, 2023
@ewbankkit
Copy link
Contributor

@bennylu2 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 66ccdb0 into hashicorp:main Mar 23, 2023
@github-actions github-actions bot added this to the v4.60.0 milestone Mar 23, 2023
@github-actions
Copy link

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_placement_group forces recreate without optional spread_level arg
3 participants